Repository navigation
Build/Test Tools: Fix Installation Tests fatal on a truncated Twenty Twenty-Two pattern file - #15152
adimoldovan wants to merge 2 commits into
Conversation
…ation Tests. WP-CLI extracts tarballs with PharData, which cuts paths at 100 characters. On WordPress 5.9 and 6.0, this breaks a Twenty Twenty-Two pattern file, and the post-install smoke check fails with a fatal error. See #66403.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
There was a problem hiding this comment.
🟡 Changes recommended
The documented wp-version: latest input uses an incorrect archive URL, causing the download to fail before installation.
1 open issue
What changed in this PR
This PR updates the Installation Tests workflow to avoid WP-CLI tarball extraction truncating long filenames, which causes WordPress 5.9 and 6.0 installation smoke checks to fail.
Changes:
- Downloads release tarballs with
curland extracts them using systemtar. - Keeps WP-CLI downloads for
nightlyandtrunk, which use ZIP archives. - Adds comments explaining the extraction workaround.
| File | Description |
|---|---|
.github/workflows/install-testing.yml |
Changes release download and extraction handling to preserve long filenames. |
Review effort: Balanced
lancewillett
left a comment
lancewillett
left a comment
There was a problem hiding this comment.
The release download uses system tar while nightly/trunk retain the ZIP download path. Local extraction passed for 5.9, 6.0, and latest, including the full Twenty Twenty-Two pattern filename. ShellCheck passed. The local actionlint warning about the existing $/ action syntax also occurs on the base workflow; GitHub lint and installation checks passed. Both linked fork installation runs passed. No blockers found.
AI review · gpt-6
Download release archives with `curl` and extract them with the system `tar` to avoid truncated filenames from `PharData`. This fixes the Twenty Twenty-Two pattern loading failure in WordPress 5.9 and 6.0 installation smoke checks. Keep `wp core download` for `nightly` and `trunk`, which use ZIP archives. Developed in: #15152 Props adrianmoldovanwp. Fixes #66403. git-svn-id: https://develop.svn.wordpress.org/trunk@65004 602fd350-edb4-49c9-b593-d223f7449a82
|
@adimoldovan Could you please follow up in a new PR/Trac ticket for how we might upgrade to latest version of WP CLI to avoid this patch? See https://core.trac.wordpress.org/ticket/66403#comment:3 |
Download release archives with `curl` and extract them with the system `tar` to avoid truncated filenames from `PharData`. This fixes the Twenty Twenty-Two pattern loading failure in WordPress 5.9 and 6.0 installation smoke checks. Keep `wp core download` for `nightly` and `trunk`, which use ZIP archives. Developed in: WordPress/wordpress-develop#15152 Props adrianmoldovanwp. Fixes #66403. Built from https://develop.svn.wordpress.org/trunk@65004 git-svn-id: http://core.svn.wordpress.org/trunk@64154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-project-automation
Bot
moved this from In review
to Done
in WordPress Project Build Tooling
The Installation Tests workflow now downloads release tarballs with
curland extracts them with the systemtar.WP-CLI 2.12.0 extracts tarballs with
PharData, which cuts paths at 100 characters. On WordPress 5.9 and 6.0,twentytwentytwo/inc/patterns/header-text-only-with-tagline-black-background.phploses its.phpextension, and the post-install smoke check fails with a fatal error. The systemtarkeeps the full path.nightlyandtrunkstill usewp core download. Nightly builds are only available as a zip, and the zip extraction does not cut paths.Testing
Run the Installation Tests workflow manually with
wp-versionset to5.9,6.0,latest, andnightly. All single-site jobs pass the smoke check.Results on my fork, with this change and the
github.repositorychecks removed so the jobs run outsideWordPress/wordpress-develop:Trac ticket: https://core.trac.wordpress.org/ticket/66403
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigation, implementation, and review. I reviewed the final change.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.