Repository navigation
Build/Test Tools: Download release zips with WP-CLI in Installation Tests - #15252
adimoldovan wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues with the WordPress release-download update.
No open issues 🎉
What changed in this PR
Updates Installation Tests to download WordPress release ZIPs through WP-CLI, avoiding tarball path truncation while retaining compatibility with older PHP versions.
Changes:
- Replaces release downloads using
curlandtarwithwp core downloadtargeting ZIP archives. - Pins WP-CLI to 2.12.0 for PHP 5.6, 7.0, and 7.1, preserving the existing 2.4.0 pin for PHP 5.4 and 5.5.
- Leaves nightly and trunk download behavior unchanged.
| File | Description |
|---|---|
.github/workflows/install-testing.yml |
Uses WP-CLI for release ZIP downloads and adds compatibility pins for older PHP versions. |
Review effort: Balanced
lancewillett
left a comment
There was a problem hiding this comment.
This follows the agreed ZIP-download approach and preserves latest/nightly/trunk handling while keeping older PHP jobs on compatible WP-CLI versions. Verified the six successful fork runs and that their workflow differs only in enabling fork execution. Locally, WP-CLI 2.12.0 downloaded the WordPress 5.9 ZIP, verified its checksum, and preserved the long Twenty Twenty-Two filename. Actionlint passes with Core’s configuration; current CI and Copilot are clear.
AI review · gpt-6
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Download WordPress release ZIP archives through `wp core download` to preserve long filenames during extraction. Keep nightly and trunk downloads unchanged. Pin WP-CLI to `2.12.0` for PHP `5.6`, `7.0`, and `7.1`, retaining the existing `2.4.0` pin for PHP `5.4` and `5.5`. Developed in: #15252 Props adrianmoldovanwp, lucatume. See #66403. git-svn-id: https://develop.svn.wordpress.org/trunk@65191 602fd350-edb4-49c9-b593-d223f7449a82
Download WordPress release ZIP archives through `wp core download` to preserve long filenames during extraction. Keep nightly and trunk downloads unchanged. Pin WP-CLI to `2.12.0` for PHP `5.6`, `7.0`, and `7.1`, retaining the existing `2.4.0` pin for PHP `5.4` and `5.5`. Developed in: WordPress/wordpress-develop#15252 Props adrianmoldovanwp, lucatume. See #66403. Built from https://develop.svn.wordpress.org/trunk@65191 git-svn-id: http://core.svn.wordpress.org/trunk@64340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
PR #15252 landed in https://core.trac.wordpress.org/changeset/65191 |
The Installation Tests workflow now downloads release zips with
wp core download, and pins WP-CLI 2.12.0 on PHP 5.6, 7.0 and 7.1.This removes the
curl+tarworkaround from [65004]. WP-CLI 2.x extracts tarballs withPharData, which cuts paths at 100 characters. It extracts zips withZipArchive, which keeps the full path.wp core downloadalso checks the MD5 hash of the zip.WP-CLI 3.0 will need PHP 7.2.24 or later. On PHP 5.6, 7.0 and 7.1 it exits with "WP-CLI requires PHP 7.2.24 or newer". The pin keeps these jobs on 2.12.0. PHP 5.4 and 5.5 stay on 2.4.0.
latest,nightlyandtrunkwork as before.nightlyandtrunkstill usewp core download --version=nightly.Testing
Run the Installation Tests workflow manually with
wp-versionset to4.9,5.9,6.0,latest,nightlyandtrunk. All install jobs pass.Results on my fork, with this change and the
github.repositorychecks removed so the jobs run outsideWordPress/wordpress-develop:latest: 70 of 70 install jobs passnightly: 70 of 70 install jobs passtrunk: 70 of 70 install jobs passThe WP 5.9 job logs for PHP 5.6 and 7.1 show
WP-CLI 2.12.0,Downloading from https://wordpress.org/wordpress-5.9.zipandmd5 hash verified.Trac ticket: https://core.trac.wordpress.org/ticket/66403
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigation, implementation, and review. I reviewed the final change.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.