Skip to content

Build/Test Tools: Download release zips with WP-CLI in Installation Tests - #15252

Closed
adimoldovan wants to merge 2 commits into
WordPress:trunkfrom
adimoldovan:66403-zip-download
Closed

adimoldovan wants to merge 2 commits into
WordPress:trunkfrom
adimoldovan:66403-zip-download

Conversation

@adimoldovan

@adimoldovan adimoldovan commented Oct 30, 2026 •

Copy link
Copy Markdown

The Installation Tests workflow now downloads release zips with wp core download, and pins WP-CLI 2.12.0 on PHP 5.6, 7.0 and 7.1.

This removes the curl + tar workaround from [65004]. WP-CLI 2.x extracts tarballs with PharData, which cuts paths at 100 characters. It extracts zips with ZipArchive, which keeps the full path. wp core download also checks the MD5 hash of the zip.

WP-CLI 3.0 will need PHP 7.2.24 or later. On PHP 5.6, 7.0 and 7.1 it exits with "WP-CLI requires PHP 7.2.24 or newer". The pin keeps these jobs on 2.12.0. PHP 5.4 and 5.5 stay on 2.4.0.

latest, nightly and trunk work as before. nightly and trunk still use wp core download --version=nightly.

Testing

Run the Installation Tests workflow manually with wp-version set to 4.9, 5.9, 6.0, latest, nightly and trunk. All install jobs pass.

Results on my fork, with this change and the github.repository checks removed so the jobs run outside WordPress/wordpress-develop:

The WP 5.9 job logs for PHP 5.6 and 7.1 show WP-CLI 2.12.0, Downloading from https://wordpress.org/wordpress-5.9.zip and md5 hash verified.

Trac ticket: https://core.trac.wordpress.org/ticket/66403

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigation, implementation, and review. I reviewed the final change.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@adimoldovan adimoldovan self-assigned this Oct 30, 2026
@lancewillett
lancewillett requested review from lancewillett and a balanced review from Copilot October 30, 2026 17:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues with the WordPress release-download update.

No open issues 🎉

What changed in this PR

Updates Installation Tests to download WordPress release ZIPs through WP-CLI, avoiding tarball path truncation while retaining compatibility with older PHP versions.

Changes:

  • Replaces release downloads using curl and tar with wp core download targeting ZIP archives.
  • Pins WP-CLI to 2.12.0 for PHP 5.6, 7.0, and 7.1, preserving the existing 2.4.0 pin for PHP 5.4 and 5.5.
  • Leaves nightly and trunk download behavior unchanged.
File Description
.github/​workflows/​install-testing.yml Uses WP-CLI for release ZIP downloads and adds compatibility pins for older PHP versions.

Review effort: Balanced

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the agreed ZIP-download approach and preserves latest/nightly/trunk handling while keeping older PHP jobs on compatible WP-CLI versions. Verified the six successful fork runs and that their workflow differs only in enabling fork execution. Locally, WP-CLI 2.12.0 downloaded the WordPress 5.9 ZIP, verified its checksum, and preserved the long Twenty Twenty-Two filename. Actionlint passes with Core’s configuration; current CI and Copilot are clear.

AI review · gpt-6

@adimoldovan
adimoldovan marked this pull request as ready for review October 31, 2026 09:53
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adrianmoldovanwp, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

wporg-sync pushed a commit that referenced this pull request Nov 2, 2026
Download WordPress release ZIP archives through `wp core download` to preserve long filenames during extraction. Keep nightly and trunk downloads unchanged.

Pin WP-CLI to `2.12.0` for PHP `5.6`, `7.0`, and `7.1`, retaining the existing `2.4.0` pin for PHP `5.4` and `5.5`.

Developed in: #15252

Props adrianmoldovanwp, lucatume.
See #66403.


git-svn-id: https://develop.svn.wordpress.org/trunk@65191 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Nov 2, 2026
Download WordPress release ZIP archives through `wp core download` to preserve long filenames during extraction. Keep nightly and trunk downloads unchanged.

Pin WP-CLI to `2.12.0` for PHP `5.6`, `7.0`, and `7.1`, retaining the existing `2.4.0` pin for PHP `5.4` and `5.5`.

Developed in: WordPress/wordpress-develop#15252

Props adrianmoldovanwp, lucatume.
See #66403.

Built from https://develop.svn.wordpress.org/trunk@65191


git-svn-id: http://core.svn.wordpress.org/trunk@64340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@lancewillett

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants