Skip to content

Enhance error handling for composer update in env:start #9360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Adi-ty wants to merge 11 commits into from
Closed

Enhance error handling for composer update in env:start #9360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
87b1a94
feat: Enhance error handling for composer update in env:start
Adi-ty Jul 30, 2025
5149d17
Merge remote-tracking branch 'upstream/trunk' into pr/9360
azaozz Jan 19, 2026
cbf3838
feat: Improve error handling for PHP composer update in local environ…
Adi-ty Jan 19, 2026
4e920e7
Merge branch 'enhancement/62807-env-start-composer-error-handling' of…
azaozz Jan 19, 2026
38d7e70
Merge branch 'trunk' into enhancement/62807-env-start-composer-error-…
Adi-ty Mar 29, 2026
62f923d
Fix: Correct syntax error in `env:start` script in package.json
Adi-ty Mar 29, 2026
288c044
Merge branch 'trunk' into enhancement/62807-env-start-composer-error-…
Adi-ty Oct 31, 2026
6ac35f5
Merge branch 'trunk' into enhancement/62807-env-start-composer-error-…
Adi-ty Oct 31, 2026
e292022
Build/Test Tools: Run the `env:start` Composer update through the ret…
Adi-ty Oct 31, 2026
d70e8f1
Merge branch 'trunk' into enhancement/62807-env-start-composer-error-…
Adi-ty Oct 31, 2026
daea153
Merge branch 'trunk' into enhancement/62807-env-start-composer-error-…
Adi-ty Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"lint:jsdoc": "wp-scripts lint-js",
"lint:jsdoc:fix": "wp-scripts lint-js --fix",
"typecheck:js": "tsc --build",
"env:start": "node ./tools/local-env/scripts/start.js && node ./tools/local-env/scripts/docker.js run -T --rm php composer update -W",
"env:start": "node ./tools/local-env/scripts/start.js",
"env:stop": "node ./tools/local-env/scripts/docker.js down",
"env:restart": "npm run env:stop && npm run env:start",
"env:clean": "node ./tools/local-env/scripts/docker.js down -v --remove-orphans",
Expand Down
11 changes: 11 additions & 0 deletions tools/local-env/scripts/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,14 @@ if ( process.env.DOCKER_TOOLBOX_INSTALL_PATH ) {
{ stdio: 'inherit' }
);
}

// `composer update` reaches repo.packagist.org, so it is re-attempted for the same reasons as `up`.
const composer = local_env_utils.compose_with_retry( [ 'run', '-T', '--rm', 'php', 'composer', 'update', '-W' ], 3 );

@lancewillett lancewillett Oct 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed after landing in r65150. A controlled before/after subprocess check shows npm run env:start -- --dry-run previously passed the flag to Composer and now drops it. Appending ...process.argv.slice( 2 ) to the Composer argument array restores forwarding; checks with zero, one and two arguments pass. This needs a follow-up fix. My earlier startup/retry probe missed argument forwarding.

AI review · gpt-6


if ( composer.status !== 0 ) {
console.error( '\nThere was an error while running PHP Composer update.' );
console.error( 'This is often caused by network issues or Packagist.org downtime.' );
console.error( 'Please check your internet connection and try again.' );

process.exit( composer.status ?? 1 );
}
Loading