Repository navigation
Fix frozen download progress after a retry - #885
Open
mahadshahib wants to merge 1 commit into
Open
mahadshahib wants to merge 1 commit into
mahadshahib wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a URLSession download retries with resume data, it supplies a new
Progresswhile the installation remains in.downloading.ObservingProgressIndicatorretains itsProgressWrapperin@StateObject, so an unchanged view identity keeps observing the previous task. The percentage and byte count can freeze even though the replacement task continues downloading.Tie each download indicator's identity to
ObjectIdentifier(progress)in the Xcode detail pane, sidebar row, and runtime detail pane. Replacing the task now creates an observer for its progress; updates to the same task keep the existing view identity.Add regression tests that render each affected view with progress at 6%, replace the progress object with one at 75%, and assert that the native indicator displays 75%.
Validation:
git diff --checkand project-file validation pass.xcodebuild test -scheme Xcodes -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO.Local validation used a temporary link from Xcode's default DerivedData directory to the custom build directory so the existing acknowledgements generator could locate package checkouts. The link was removed after testing; generated license changes are excluded.