You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: expose none reasoning effort for OpenAI-compatible models - #2063
Added the none reasoning-effort option for OpenAI-compatible models. Selecting it saves the setting and includes none in API requests; tests cover settings and request construction in OpenAICompatible.tsx and openai.spec.ts.
Reviewer note: the option is now exposed for all OpenAI-compatible models, without checking endpoint-specific support.
Test Procedure
Pre-Submission Checklist
Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
Scope: My changes are focused on the linked issue (one major feature/fix per PR).
Self-Review: I reviewed my own code with care.
Writing Style: The PR title and description use Simplified Technical English (ASD-STE100): short sentences, plain words, active voice, one idea per sentence, no contractions.
Testing: New and/or updated tests have been added to cover my changes (if applicable).
Visual Snapshot (UI changes only): If a user would notice this change at a glance (layout, theme tokens, brand elements, empty/error states), I added or updated a *.visual.tsx snapshot in webview-ui/. See webview-ui/AGENTS.md → "When a UI change needs a snapshot".
Documentation Impact: I checked if my changes need documentation updates (see "Documentation Updates" section below).
Auto reviews are limited based on label configuration.
🏷️ Required labels (at least one): 1
coderabbit-review-active
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
New Features
OpenAI-compatible models now support selecting “None” as the reasoning effort, and the setting is preserved in requests that use tools.
The OpenAI-compatible provider now advertises "none" as a supported reasoning-effort value. Tests cover selecting and saving that value and sending it with a function tool in a streaming request.
Changes: Reasoning effort setting
Layer / File(s)
Summary
Expose and verify the none option webview-ui/src/components/settings/providers/OpenAICompatible.tsx, webview-ui/src/components/settings/providers/__tests__/OpenAICompatible.spec.tsx, webview-ui/src/components/settings/__tests__/ThinkingBudget.spec.tsx, src/api/providers/__tests__/openai.spec.ts
The provider lists "none" as a supported reasoning-effort value. Tests cover its availability, persistence when selected, and inclusion in a streaming request with the read_file tool.
The change appears ready to merge after normal checks. No merge-blocking issue was identified.
Pre-merge checks: 6 · 2
Failed checks: 2 warnings
Check name
Status
Explanation
Resolution
Regression Evidence
The PR adds a user-visible none option at webview-ui/src/components/settings/providers/OpenAICompatible.tsx:333, but it adds no Playwright component snapshot. The existing visual fixtures cover Az…
Add a Playwright gallery story and committed component snapshot for the OpenAI-compatible reasoning-effort control with reasoning enabled. Open the selector or otherwise render its options so the none option and the resulting visible stat…
Description check
The description links issue #2040 and explains the implementation and scope. However, the Test Procedure is empty, and the required pre-submission checklist remains unchecked.
Add reproducible test steps and relevant environment details. Complete the pre-submission checklist, including the testing and documentation items.
Passed checks: 6 passed
Check name
Status
Explanation
Linked Issues check
Issue #2040 requires a way to send reasoning_effort: "none" for OpenAI-compatible chat-completions requests, or to route requests through /v1/responses. This PR implements the settings path: `Open…
Out of Scope Changes check
The changed provider setting exposes the option required by issue #2040. The API regression test verifies the required request behavior. The settings tests verify persistence and supported-option wiri…
Security Boundaries
No changed path violates the security boundaries. The only production change adds the fixed value "none" to the OpenAI-compatible reasoning-effort option list in `webview-ui/src/components/settings/…
Persistence Integrity
No changed persistence defect exists. The PR only adds the "none" option and tests. Selecting it synchronously updates openAiCustomModelInfo.reasoningEffort through OpenAICompatible.tsx; `Settings…
Lifecycle Resource Cleanup
No changed lifecycle path can leak a resource or duplicate work. The only production change adds "none" to the existing supportsReasoningEffort array in OpenAICompatible.tsx. Other changes add tes…
Title check
The title clearly and concisely describes the main change: exposing the none reasoning-effort option for OpenAI-compatible models.
Full details: Regression Evidence
Explanation
The PR adds a user-visible none option at webview-ui/src/components/settings/providers/OpenAICompatible.tsx:333, but it adds no Playwright component snapshot. The existing visual fixtures cover Azure guidance and Extra Body only, and ThinkingBudget.visual.tsx covers a Bedrock budget slider. Vitest tests cover option wiring and persistence, but they do not provide the required durable visual evidence for the changed settings UI.
Resolution
Add a Playwright gallery story and committed component snapshot for the OpenAI-compatible reasoning-effort control with reasoning enabled. Open the selector or otherwise render its options so the none option and the resulting visible state are covered.
Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
🧰 Additional context used
📓 Path-based instructions: 7
Treat model, provider, MCP, path, command, and tool data as untrusted.
CodeRabbit configuration file
Files:
src/api/providers/__tests__/openai.spec.ts
For persisted settings, verify the complete schema/storage/runtime/webview round trip, shared default semantics, and focused true plus false/unset tests.
Require regression coverage at the lowest valid harness with behavior-focused assertions, including relevant negative, error, false/unset, and boundary cases.
Thanks for contributing. This comment tracks the review sequence and the next action.
Current step: Mark the PR ready. Required CI must pass before CodeRabbit starts.
Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.
This PR has been awaiting author changes for 14 days and will be automatically closed in 7 days. Please address the review comments or leave a comment if you need more time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
coderabbit-review-active
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Related GitHub Issue
Closes: #2040
Description
Added the none reasoning-effort option for OpenAI-compatible models. Selecting it saves the setting and includes none in API requests; tests cover settings and request construction in OpenAICompatible.tsx and openai.spec.ts.
Reviewer note: the option is now exposed for all OpenAI-compatible models, without checking endpoint-specific support.
Test Procedure
Pre-Submission Checklist
*.visual.tsxsnapshot inwebview-ui/. Seewebview-ui/AGENTS.md→ "When a UI change needs a snapshot".Visual Snapshots
Videos (interaction / animation only)
Documentation Updates
Additional Notes
Get in Touch