Repository navigation
Conversation
|
@Krshivam25 is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 14, 2026
The heading was passed to Trans as a runtime variable, so lingui extracted the
variable name and the catalogs carried the msgid {popularSectionTitle} instead of
the text. Neither heading could be translated in any locale. Branch on the JSX so
both literals are statically extractable.
Closes aave#3135
shivam-V8
force-pushed
the
fix/3135-translatable-popular-heading
branch
from
October 24, 2026 08:38
92c8fa4 to
bd77c88
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heading was passed to Trans as a runtime variable, so lingui extracted the variable name and the catalogs carried the msgid {popularSectionTitle} instead of the text. Neither heading could be translated in any locale. Branch on the JSX so both literals are statically extractable.
Closes #3135
General Changes
Developer Notes
Root cause — the heading was built as a runtime variable and then passed to
<Trans>:lingui extracts the expression, not the strings behind it, so the committed catalog carried the variable name itself
Neither real string appeared as a msgid anywhere in src/locales/, so no locale could translate either one and every user saw English. SwitchAssetInput is shared by all five swap flows (swap, collateral swap, debt swap, repay with collateral, withdraw and swap), so the untranslated heading showed in each of them.
Change — branch on the JSX so both literals are statically analysable, and drop the now-unused variable:
Evidence — the catalog diff after pnpm i18n is the proof that the extraction now works:
The regenerated catalogs are included in the commit, and a second pnpm i18n run produces no further diff, so i18n-check passes.
Tests — none added. There is no pure logic here to unit test; the catalog diff above is the verification. tsc --noEmit and next lint are both clean for the changed file (lint would also have caught the removedl referenced it), and the jest suite is unchanged.
Related, not included — the same pattern appears once more ineTitle || 'Balance'}. I left it out to keep this change to the reported bug; happy to fold it in or send a follow-up, whichever you prefer.
Pre-existing failures — the 4 jest suites in src/utils/ that fail on main (a wagmi/chains import issue) are unaffected.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
Related work
Part of a set of small, independently reviewable fixes found while testing the v3 uplift. Each closes its own issue, touches one concern, and branches from
main, so they can be reviewed and merged in any order: