Repository navigation
feat(protocol)!: adopt the signed AdCP 3.3.0-rc.0 bundle - #1919
Merged
Merged
Conversation
Pin src/adcp/ADCP_VERSION to 3.3.0-rc.0 from the audited, cosign-verified release: schemas/releases/3.3.0-rc.0.json, source commit 620b161718be from the Fulcio certificate (the tag is its Version Packages child), bundle sha256 bdcacb0bb548. Resync the schema cache, packaged compliance inputs, request-signing vectors and skills, regenerate the types from the beta.6 tree and the public API snapshot. The wheel ships the rc.0 schemas and compliance tree; the beta.6 trees stay in the repository as history. Renamed experimental values (adcp#8901), with no alias: input_required to input-required in execution readiness, click_through to clickthrough in creative change kinds, underdelivery to under_delivery in delivery projections. Reserved-word-safe replacements (adcp#8791): passed for pass, all for global, full_name for name. The originals stay valid through 3.x; version conversion rewrites a replacement to the original it supersedes for a peer below 3.3, reading x-superseded-by from the 3.3 schema. authorized_agents multi-match (adcp#8943, #9016): every entry matching an agent authorizes it, and fetch_publisher_signing_pins pins the agent only if every matching entry carries signing_keys, as the union of their keys, with the earliest revoked_at for copies of one key. This replaces the beta.6 exact-entry-wins rule. SDK-hosted reporting advertised supported_versions without any "-rc" release, which would have dropped the packaged 3.3-rc.0 itself; it now leaves out only the compatibility aliases (3.2-rc.7). Also generated: creative.assignment_operations (adcp#8933), image_carousel cta_values, social distribution identifiers, the audience_targeting capability split, campaign governance human_review_required, and the aligned submitted branches. BREAKING CHANGE: the SDK no longer advertises or accepts AdCP 3.3-beta.6. get_supported_adcp_versions is 3.0, 3.1, 3.2, 3.3-rc.0 and 3.2-rc.7; an adcp_version pin of 3.3-beta.6 or 3.3.0-beta.6 raises ConfigurationError, and a peer that advertises only 3.3-beta.6 for the 3.3 line negotiates down to 3.2. Re-pin to 3.3-rc.0 or omit the pin. The experimental values input_required, click_through and underdelivery are renamed with no alias, and fetch_publisher_signing_pins now returns the union of every matching entry's pins, or None when any matching entry is unpinned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bokelley
requested review from
KonstantinMirin and
rachitm022
as code owners
November 17, 2026 02:50
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean schema-adoption PR pinning AdCP 3.3.0-rc.0.
What I checked:
- Decision table top-down: no critical/high/medium findings (rows 1, 4, 5, 8 don't fire). gated_paths is false (row 2 n/a). No
(deleted)entries — all high-risk matches are(added)schema cache files (row 3 n/a). No prior decision (row 6 n/a). No no-auto-approve team match (row 7 n/a). Falls through to row 9 → approve. high_risk: trueis driven entirely by newly-addedschemas/**cache files(added)— per arbiter guidance, a PR that only adds new files matching high-risk globs is normal scaffolding, not escalation-worthy on the flag alone.- Semver signal is correct: the breaking surface (3.3-beta.6 no longer accepted, three experimental enum renames with no alias, fetch_publisher_signing_pins return-shape change) carries
feat(protocol)!+ a BREAKING CHANGE footer and migration notes. - Hand-written logic changes reviewed and test-covered: adagents.py signing-pin merge is fail-closed; compat/versions.py superseded-enum passthrough is correct; reporting/service.py supported_versions filter has the right shape. Forward-compat unions, aliases.py, _ergonomic.py untouched; _generated.py change is regen output.
No blocking or medium findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the signed AdCP
3.3.0-rc.0bundle, the first 3.3 release candidate, on the SDK 10 /nextline. It follows #1901 (beta.6) and ships as the next 10.0.0 beta.Pin
schemas/releases/3.3.0-rc.0.jsonrecords:620b161718be, from the Fulcio certificate (thev3.3.0-rc.0tag,b5ac0e1b, is its "Version Packages" child);bdcacb0bb548…, 27,800,935 bytes;.sig,.crtand.sha256sidecars.cosign verify-blobagainstrelease.yml@refs/heads/mainprintsVerified OK.sync_schemas.py's own cache, skills, vector, compliance and patch functions.sync_schemas.py --require-signed-releasefrom the CDN, followed byfix_schema_refs.py, verified the checksum and exact signing identity and left the committed tree unchanged. (CI skips its CDN download and drift steps for a prerelease pin, so this local re-sync is the CDN check.)SCHEMA_DELTAS.mdis the full beta.6 → rc.0 delta.What rc.0 changes, and what the SDK does
input_required→input-required,click_through→clickthrough,underdelivery→under_deliverypassed,all,full_namereplace the deprecatedpass,global,name; a replacement goes only to peers on 3.3 or laterx-superseded-byfrom the 3.3 schema'senumMetadata, so a 3.2 buyer getspass, not a refusal. Untypederror.details(theRATE_LIMITEDscope) isn't rewritten.authorized_agentsmulti-match (adcp#8943, #9016)fetch_publisher_signing_pinsnow follows the rule. Every matching entry counts, the agent is pinned only if every one carriessigning_keys, the pin is their union, and copies of a key keep the earliestrevoked_at. This replaces the beta.6 "exact entry wins / exactly one" rule. It's evaluated per publisher domain; a message's narrower scope isn't.creative.assignment_operations(adcp#8933)assignment_operationsmust now declare them; this is noted in MIGRATION.image_carouselcta_values, aligned submitted branches (#8856), governancehuman_review_requiredFix the candidate exposed
ReportingServiceadvertises a defaultsupported_versionsfor subscriptions (#1771). It filtered out every release containing-rc, meant to drop the3.2-rc.7alias. With the packaged pin at3.3-rc.0, that would have hidden the 3.3 line from buyers. It now leaves out only compatibility aliases.Reporting vectors and storage contract
REPORTING_STORAGE_CONTRACT == STORAGE_CONTRACT == 2, and no ledger changes.Not done (follow-ups)
all→globalinsideRATE_LIMITEDerror.detailsfor 3.2 peers.assignment_operationsentry the seller doesn't list.assign.Breaking
3.3-rc.0and no longer accepts3.3-beta.6.get_supported_adcp_versions()is3.0, 3.1, 3.2, 3.3-rc.0, 3.2-rc.7.fetch_publisher_signing_pinsreturns the union of every matching entry's pins, orNonewhen any matching entry is unpinned.Recorded in
MIGRATION_v9_to_v10.mdanddocs/adcp-3.3-sdk-inventory.mdsection 17.Verification
make validate-generatedandmake lintpass.make typecheck-all: every contract passes (mypy on 1,707 source files, adopter fixtures, pyright).test_current_signed_compliance_bytes_ship_in_each_distribution, came from a stale gitignoredbuild/libleft by the provisional dry run; after clearing it the module passes.tests/test_reserved_word_replacements.pyandtests/test_adagents_matching.pycover the new conversion and signing-pin behaviour.BREAKING CHANGE: the SDK no longer advertises or accepts AdCP 3.3-beta.6. get_supported_adcp_versions is 3.0, 3.1, 3.2, 3.3-rc.0 and 3.2-rc.7; an adcp_version pin of 3.3-beta.6 or 3.3.0-beta.6 raises ConfigurationError, and a peer that advertises only 3.3-beta.6 for the 3.3 line negotiates down to 3.2. Re-pin to 3.3-rc.0 or omit the pin. The experimental values input_required, click_through and underdelivery are renamed with no alias, and fetch_publisher_signing_pins now returns the union of every matching entry's pins, or None when any matching entry is unpinned.
🤖 Generated with Claude Code