Repository navigation
fix(reporting): suppress unchanged revisions and require stable close evidence - #1921
rachitm022 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean review, no blocking or medium findings.
No no-auto-approve team match; gated_paths is false; high_risk is false. review_decision is REVIEW_REQUIRED, but with gated_paths=false that does not force escalation (row 2 only fires when gated_paths is true). No findings in the reviewer list, so rows 1, 4, 5, 6, and 8 do not apply.
What was checked: unchanged-read suppression and the opt-in official_stability_duration close are internally consistent across both store backends (pg.py and store.py). The retained-predecessor path fires only on fingerprint match (producer.py:2016); a changed read roots its supersede at the retained leaf (producer.py:1789); the revision is None snapshot-predecessor path mirrors across backends (predecessor-equals, finality=='snapshot', account/obligation scope, current-leaf check), so an observation cannot re-point to a superseded or cross-obligation revision. _record_unpublished_official_attempt advances the ordinal for a fresh source_execution_key per retry; missing source finality-evidence fails retryable rather than silently; the dropped UNIQUE constraint migrates via idempotent DROP CONSTRAINT IF EXISTS with schema object count (27→25) reconciled in tests. All public-surface additions are optional fields.
Non-blocking notes: commit_provisional_observation widens revision to ... | None, a contract change for custom-store adopters — acceptable given the subsystem is explicitly qualification-pending. The pg revision=None branch is CI-only (31 pg cases skipped locally).
Falls through to row 9: approve.
Why
Scheduled reporting rechecks created a revision and notification even when source content was unchanged. ESA's package definition also needs an official close only after the 90-day window and a day of source stability backed by authoritative evidence.
What changed
Verification
httpcore2._backends.base.SOCKET_OPTIONexport error insrc/adcp/signing/ip_pinned_transport.py.