Repository navigation
fix(http): skip non-object JSON in SSE streams - #172
Merged
PsiACE merged 1 commit intoOct 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a connection-scoped SSE event contains valid JSON that is not an object (for example,
data: []), the HTTP client passes it to JSON-RPC routing, which assumes a dictionary. The resulting exception closes the stream, andreceive()returnsNoneinstead of delivering the next valid response.Skip non-object payloads in the shared SSE decoder, just as it already skips invalid JSON. This matches the existing object filtering in the WebSocket and NDJSON transports. JSON objects continue through the normal JSON-RPC handling unchanged.
Validation
session/newresult.httpx2.MockTransportserver and verify delivery of a valid response immediately after the invalid event.uv run python -m pytest tests/http/test_sse.py tests/http/test_http_client.py -q: 28 passed.make check: passed (lockfile, repository-wide pre-commit, Ruff, ty, deptry).make test: 448 passed, 1 skipped (optional Gemini CLI test).No public API, configuration, or schema changes. The parser docstring documents the skip behavior. No live model calls were made.
AI assistance disclosure: Codex prepared the patch, tests, and this description, and ran the checks above. No human code review is claimed.