Skip to content

test(sandbox): terminal_group_signal_precedes_the_first_descendant_collect fails on 4-vCPU runners #5811

Closed

Description

@SDAChess

User Story

I maintain OpenShell CI. While moving Branch Checks to standard GitHub-hosted runners (#4554), I hit a sandbox unit test that fails there but passes on the old 8-core runners, so the Rust test jobs cannot go green.

Description

openshell-sandbox boundary_io::tests::terminal_group_signal_precedes_the_first_descendant_collect (crates/openshell-sandbox/src/boundary_io.rs) fails on 4-vCPU GitHub-hosted runners:

thread 'boundary_io::tests::terminal_group_signal_precedes_the_first_descendant_collect' panicked at crates/openshell-sandbox/src/boundary_io.rs:1514:13:
the registered group must be signaled before the first descendant collect returns
Runner Result
NVIDIA linux-amd64-cpu8 / linux-arm64-cpu8 (every run since #5217) passes
ubuntu-24.04 (x86_64, 4 vCPU), 3 runs fails 3/3
ubuntu-24.04-arm (4 vCPU), 2 runs fails 1/2

Everything else in the suite passes (9867 of 9868 tests). Failing runs: https://github.com/NVIDIA/OpenShell/actions/runs/44714182435 (both Linux jobs) and https://github.com/NVIDIA/OpenShell/actions/runs/44714186041 (x86_64).

The test signals the registered process group with SIGSTOP from a second thread, parks the first /proc descendant collect through the collect hook, and then gives the root process 2 seconds to show as stopped. Because it passes intermittently on arm and never on 4-core x86, this looks like a race in the test rather than a product bug: if a collect other than the signal path's reaches the hook first and parks while holding a lock the signal path needs, SIGSTOP is not sent before the 2-second deadline. That hypothesis is unconfirmed.

Context

The test is marked #[ignore] so the CI move can land. It was added in #5217.

Definition of Done

  • The race is understood, and the test or the code it covers is fixed so it passes reliably on 4-vCPU runners.
  • The #[ignore] is removed.

Activity

  1. added
    state:acceptedA maintainer decided OpenShell should pursue this issue
    area:runtimeSandbox execution, isolation, supervision, policy enforcement, networking, and provider lifecycle.
    topic:testingUnit, integration, regression, conformance, E2E tests, coverage, flakes, and test infrastructure.
    on Nov 20, 2026
  2. self-assigned this
    on Nov 20, 2026
  3. added a commit that references this issue on Nov 20, 2026
    fe8bd8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:runtimeSandbox execution, isolation, supervision, policy enforcement, networking, and provider lifecycle.state:acceptedA maintainer decided OpenShell should pursue this issuetopic:testingUnit, integration, regression, conformance, E2E tests, coverage, flakes, and test infrastructure.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions