Repository navigation
feat(sdk): retry TypeScript sandbox create on lock timeout - #5725
ericcurtin wants to merge 4 commits into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
@ericcurtin @EmilienM , won't it be better to have this retry in other SDKs too ?, Python, Typescript etc, to have a consistent behaviour |
|
I was also working on this issue, I'll post the PR. Happy to close mine and keep yours. |
|
@EmilienM , we can take this PR for Rust & CLI, and can we repurpose this PR to fix for other SDKs if its okay |
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
…d TypeScript Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
@ericcurtin heads up that this overlaps heavily with #5745, which covers the same core/SDK/CLI/server ground for #5697 and is through review. Divesh suggested splitting the work by SDK; the proposal on #5745 is to merge it as the Rust/CLI/server base and cover the remaining SDKs as follow-ups. If you want to keep this PR going, the TypeScript retry is the piece that doesn't exist yet and would fit well here as a TS-only change. Two things would need to move either way: python/openshell is frozen in-tree (Branch Checks fails PRs that touch it), so the Python side belongs in ai-openshell/sdk-python; and the new SANDBOX_DELETING reason is a public API addition, which #5745 deliberately parked in favor of a client-side phase poll. Happy to compare notes if you prefer the server-side signal. |
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
@FrostGod for review please |
Summary
Retry TypeScript SDK sandbox create on
MUTATION_LOCK_TIMEOUT.Related Issue
Part of #5697. Rust, CLI and server are in #5745.
Changes
SandboxClient.createandcreateFromTemplateretry for up to 60s.Release Notes
The TypeScript SDK retries sandbox create when the gateway is busy.
Testing
mise run sdk:ts:cipasses.Checklist