Repository navigation
Conversation
Tool groups that searched the web now get a "Sources · N" row under them, built like the viewed-images row. It stays visible while the group is collapsed and expands to a deduped list of the pages the search returned, opening each in the browser. Web, desktop and mobile share the derivation in client-runtime; providers that send no result URLs get no row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Superseded by pingdotgg#38959. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an agent searches the web, the pages it found are buried. They sit three clicks deep (tool group → search row → output), behind query labels, and the reply itself shows no usable sources. Upstream #30979 reports the garbled inline citations. pingdotgg/t3code#36338 hides those markers but explicitly leaves out readable, clickable sources.
Change
A tool group that searched the web now gets one Sources · N row under it. It stays visible while the group is collapsed. Clicking it expands a list of the pages the searches returned (title and site), and each one opens in the browser. Clicking it again collapses the list.
There's no server or contract change, because
web_searchturn items already carryresultsto the client. A sharedworkEntriesWebSources()inclient-runtimekeeps http(s) URLs, drops#fragmentduplicates and falls back to the hostname when a title is missing. Web/desktop and mobile each add a row built like the existing viewed-images row, and its open state lives in the same expanded-groups state as tool groups, so it survives virtualized scrolling.Providers that send no result URLs (Codex today sends only queries) get no row, and their existing search rows are unchanged.
Scope
A small feature. Upstream accepts features only from the team or vouched contributors, so this PR lives on the fork and the idea is proposed upstream in pingdotgg/t3code#38958.
Verification
vp test run packages/client-runtime/src/work-log/presentation.test.ts: 21 passed, including a new case covering dedupe across searches, fragment collapse, non-http and malformed URLs, missing titles, and non-search entries in the group.vp test run apps/web/src/components/chat/MessagesTimeline.logic.test.ts apps/mobile/src/lib/threadActivity.test.ts: 178 passed (existing timeline behavior unchanged).packages/client-runtime,apps/webandapps/mobile. Pre-commit format, lint and knip pass.vp run check:changedcould not run on this Windows machine (spawn ENAMETOOLONG), and mobilei18n:checkfails here before generating (a WindowsspawnSyncissue in the script). The new key98e8f91616613574matches whatgt generateproduced for both apps.Created with Claude Opus 5.5 in Claude Code, running in T3 Code.