Repository navigation
fix(@angular/build): include dataurl option in global stylesheet config hash - #34135
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates the "dataurl" option into the global stylesheet config hash calculation and adds a test case to verify that changing this option alters the generated hash. The review feedback suggests normalizing "options.dataurl" to a boolean (e.g., "options.dataurl ?? false") to ensure that omitting the property versus explicitly setting it to "false" does not result in different cache hashes due to JSON serialization. Additionally, it is recommended to add a test case to verify this normalization behavior.
…ig hash The global stylesheet configuration hash did not include the 'dataurl' option from 'BundleStylesheetOptions'. When persistent stylesheet caching is enabled, toggling or changing the 'dataurl' option should invalidate cached stylesheet bundles.
1af4215 to
bb89fc5
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The global stylesheet configuration hash did not include the 'dataurl' option from 'BundleStylesheetOptions'. When persistent stylesheet caching is enabled, toggling or changing the 'dataurl' option should invalidate cached stylesheet bundles.