Repository navigation
[Backport 20.3.X] fix(@angular/build): serialize server manifest asset paths - #34510
Merged
alan-agius4 merged 2 commits intoOct 27, 2026
Merged
alan-agius4 merged 2 commits into
alan-agius4 merged 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request ensures that asset paths, base hrefs, and other manifest values are safely serialized using JSON.stringify instead of direct interpolation, preventing syntax errors when these values contain JavaScript string delimiters like single quotes. Unit and end-to-end tests have been added to verify this behavior. Feedback is provided on the test helper evaluateManifest to use a more robust regular expression when replacing 'export default', preventing accidental replacements if that substring appears within serialized content.
Serialize the values embedded in the generated server manifests with `JSON.stringify`, so a prerendered route such as `ssg/customer's-choice` no longer produces an invalid manifest.
alan-agius4
force-pushed
the
fix/server-manifest-serialization-20.3.x
branch
from
October 26, 2026 10:28
a50e3c9 to
d6f0816
Compare
alan-agius4
approved these changes
Oct 27, 2026
alan-agius4
added
action: merge
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #34493