Repository navigation
test: improve E2E test cleanup and assertion reliability - #34601
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request improves E2E test robustness and cleanup by wrapping configuration changes and tool executions in try-finally blocks, ensuring that temporary files are deleted and global packages are uninstalled. The review feedback points out a critical issue where local developer configurations (~/.angular-config.json) could be permanently deleted during local test runs, recommending a backup and restore mechanism instead. Additionally, it suggests wrapping directory restoration in a try-catch block to guarantee that global package uninstallation is never bypassed.
clydin
approved these changes
Oct 30, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several reliability and cleanup issues identified across E2E test suites: