Repository navigation
perf(@angular/build): reuse precomputed hash for in-memory build asset ETags - #34641
Merged
alan-agius4 merged 1 commit intoNov 3, 2026
Merged
Conversation
…t ETags Reuse the precomputed outputFile.hash on in-memory ResultFile entries in createBuildAssetsMiddleware instead of recomputing a SHA256 digest on every HTTP request.
angular-robot
Bot
added
area: performance
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes the Vite assets middleware by utilizing precomputed hashes for memory-based output files instead of recalculating them on every request, and adds comprehensive unit tests to verify this behavior. The feedback suggests adding a fallback to calculate the hash if outputFile.hash is undefined to prevent invalid ETags.
alan-agius4
added
target: patch
alan-agius4
requested review from
AleksanderBodurri and
clydin
and removed request for
AleksanderBodurri
November 3, 2026 08:52
alan-agius4
added
target: minor
clydin
approved these changes
Nov 3, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the precomputed
outputFile.hashon in-memoryResultFileentries increateBuildAssetsMiddlewareinstead of recomputing a SHA256 digest on every HTTP request.