Repository navigation
refactor(@angular/build): remove unused exports - #34651
Merged
Merged
Conversation
Remove the `export` keyword from four symbols that are only referenced within their defining file: `calculateThresholds` and `checkThresholds`, whose external callers moved to `checkBudgets` in 4d27c38; `augmentAppWithServiceWorkerCore`, which is only called by the exported wrapper functions; and `getEntryPointName`, whose external call sites were removed in 75abe2c. The two threshold functions also leave the unsupported `private` entry point, which re-exports the bundle calculator module; neither `@angular-devkit/build-angular` nor `@angular/cli` references them, and both still compile. The public API golden is unchanged.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restricts the visibility of several utility functions across the codebase—specifically getEntryPointName, calculateThresholds, checkThresholds, and augmentAppWithServiceWorkerCore—by removing their export keywords to make them internal to their respective modules. There are no review comments to address, and I have no feedback to provide.
MeAkib
force-pushed
the
refactor/build-unused-exports
branch
from
November 4, 2026 09:45
142ce9e to
f54bd49
Compare
alan-agius4
added
target: patch
alan-agius4
approved these changes
Nov 4, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
exportkeyword from four symbols that are only referenced within their defining file:calculateThresholdsandcheckThresholds, whose external callers moved tocheckBudgetsin 4d27c38;augmentAppWithServiceWorkerCore, which is only called by the exported wrapper functions; andgetEntryPointName, whose external call sites were removed in 75abe2c. The two threshold functions also leave the unsupportedprivateentry point, which re-exports the bundle calculator module; neither@angular-devkit/build-angularnor@angular/clireferences them, and both still compile. The public API golden is unchanged.