Repository navigation
test: replace expired self-signed SSL certificates in tests - #34676
Merged
alan-agius4 merged 1 commit intoNov 9, 2026
Merged
Conversation
crisbeto
approved these changes
Nov 9, 2026
Collaborator
Author
There was a problem hiding this comment.
Code Review
This pull request updates the mock SSL certificates and private keys across several dev-server test files, replacing the older RSA-based credentials with Elliptic Curve (EC) ones. The review feedback correctly points out that the newly added self-signed certificate has a validity start date in the future (October 2026), which could lead to latent test failures in environments with strict SSL validation, and recommends regenerating the certificate with a start date in the past.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces expired self-signed SSL certificates in unit and E2E tests with the 100-year valid
CN=localhostcertificate already used inssl_spec.ts(valid until 2126).