Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
|
@codex review Please review the complete PR candidate at head |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
@codex review Please review the complete candidate |
|
@codex review Please review the complete candidate Existing native fork check/test runs remain queued on their configured Blacksmith runners, and upstream workflow approval remain separate merge gates. No queued run, merge-tree compatibility, draft/readiness marker or supplementary CLI review is being claimed as code acceptance. Pending request scope amended for target movement; no additional review request was submitted. The complete unchanged-head comparison remains the scope. |
Issue for this PR
Addresses #52300 (local package-directory manifest entrypoint discovery). Direct file-path configuration is unchanged; that separate part of the issue is not claimed fixed.
Type of change
What does this PR do?
Resolve local plugin directories through their package manifest before asking the runtime to resolve the resulting entrypoint. Packages using
main: dist/index.jsor conditionalexportsthen load when configured by their directory.Use
resolve.exports@2.0.3for conditional maps. Respect deliberately unexported server/TUI/RPC files, reread manifests during reload, and retain the configuration layer's real-path containment checks. No API contract changes or generated client edits.How did you verify your code works?
Prior verification for candidate
5e7a5194045ed39589779bd8a7160dadb18cb071, baseline5183ea45c39aaabf14236d0ce8ae0b086d9c31e8:bun run check: all 36 tasks passed in a bounded 10 GiB scope.--skip-install --skip-web-ui. Independently packed/installed Claude and Jev plugins loaded directly from their package directories and passed direct/routed shared-backend streaming, concurrent-project reload and real read-tool continuation fixtures.These are the original candidate's offline receipts, not current-live-target hosted acceptance. Native fork check/test runs
37781818149/37781824801at the unchanged head are still queued without assigned Blacksmith runners; no application tests ran in those jobs. Upstream runs 37674316679, 37674316670 and 37674316719 require maintainer approval. Current full-candidate native Codex review and required application CI remain outstanding; standards/compliance success does not replace them. Actual subscription inference is outside the offline tests. No local tests or builds were run during this maintenance pass.Screenshots / recordings
Not applicable: package loading change with no UI changes.
Checklist