[xiaobai0529]

Summary

• Route the Substrait decimal conversion through \Decimal128Type::Make().
• Add a regression test using the 220-byte plan from Apache Arrow Substrait DeserializePlan fatal ARROW_CHECK abort on out-of-range decimal precision (Decimal128Type ctor via FromProtoImpl make_shared bypass) #50230.

Root cause

The decimal arm used \FromProtoImpl, which constructs the type with \std::make_shared\ and bypasses the validating factory. An untrusted precision of 42 reached the constructor's fatal \ARROW_CHECK_OK, aborting \DeserializePlan\ instead of returning \Status::Invalid.

Fixes #50230

Verification

• Without the production change, the regression test aborts at \Decimal precision out of range [1, 38]: 42.
• With the change, focused regression test passes.
• Full \�rrow-substrait-substrait-test\ suite: 101 passed.
• \clang-format --dry-run --Werror\ and \git diff --check\ passed.

AI assistance

I used an AI coding assistant for investigation and drafting this patch. I reviewed the final diff and ran the before/after tests locally.

• GitHub Issue: Apache Arrow Substrait DeserializePlan fatal ARROW_CHECK abort on out-of-range decimal precision (Decimal128Type ctor via FromProtoImpl make_shared bypass) #50230

[github-actions]

Thanks for opening a pull request!

This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format.

If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

After updating the title, you can mark the pull request as ready for review.

See also:

• Other pull requests
• Contribution Guidelines - Contributing Overview

[github-actions]

⚠️ GitHub issue #50230 has been automatically assigned in GitHub to PR creator.

[github-actions]

⚠️ GitHub issue #50230 has no components, please add labels for components.

[dmitry-chirkov-dremio]

Approving as is but additional test cases for boundary conditions would be a cherry on top.

[dmitry-chirkov-dremio]

Let's do a "classic" boundary check tests with 0, 1, 38, or 39, please?