Repository navigation
Reserve extra bthread workers for blocking event loops - #3683
Merged
chenBright merged 2 commits intoOct 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Three unresolved moderate findings remain: the shared epoll thread can pin workers to the first caller's bthread tag, dispatcher reservation failures now abort at startup via CHECK_EQ, and a test timeout can leave a thread holding dangling stack references.
3 open issues
Review effort: Lite
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What problem does this PR solve?
Issue Number: resolve #1120
Problem Summary:
When event dispatchers occupy all bthread workers in
epoll_waitorkevent,other bthreads cannot run. This can stall request processing and server shutdown,
particularly when
event_dispatcher_num >= num_threads.What is changed and the side effects?
Changed:
bthread_add_reserved_concurrency_by_tag(num, tag)to increment reserved concurrency.created eagerly, including when lazy growth is enabled.
TaskControl::concurrency()as their total.even when normal concurrency reaches its limit.
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: