You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add URMA runtime recovery and TCP fallback - #3708
URMA can fall back to TCP during connection setup, but established failures do not guide subsequent connection attempts. A failed server SEND can close the control socket while the client immediately reconnects over URMA to the same peer.
What is changed and the side effects?
Add process-level LEGACY, AUTO and TCP_ONLY modes. AUTO applies a configurable peer cooldown, defaulting to 5 seconds; LEGACY remains the default. New connections use TCP during cooldown and can select URMA afterward.
Report completion, JFC and WR-posting failures once per connection. Ignore reports from earlier policy epochs, count access errors separately and preserve EAGAIN for backpressure.
Report established client control-socket EOF/read failures so server-side faults also trigger peer cooldown. Normal server-side EOF from short clients closes the connection without cooling down the peer.
Select CTP/RTP paths from device capabilities, release short-connection resources, serialize TCP reads and initialize/validate send SGEs. Optional aligned copied sends add one payload copy.
Add a recovery client, process-local SEND fault injection, independent regression tests, documentation and a URMA mock CI workflow.
Mode changes affect new connections. Short connections can resume URMA after cooldown; established single/pooled TCP connections can continue serving RPCs. Existing v2/v3 wire formats remain compatible.
Validation
Current community CI checks pass. The URMA mock workflow passes all 15 regression groups with RDMA disabled and URMA enabled.
The server-SEND regression reproduces the missing client cooldown before the fix. All 8 CTP/RTP, v2/v3 and event/polling combinations pass after it, covering normal short closes, TCP cooldown, URMA recovery and 64 KiB attachment validation.
Prior URMA RM/RTP hardware runs passed TCP_ONLY, v2/v3 AUTO, runtime mode switching and single/pooled 64 KiB/1 MiB attachment checks. Client SEND-post injection passed event short/single/pooled and polling short runs with 1 MiB attachments: one expected RPC failure per run, subsequent RPC recovery and zero content-validation failures. Short connections resumed URMA after TCP cooldown.
Related discussions and PRs
Discussion #3711: runtime recovery and business QoS configuration.
On the RDMA question: URMA-only is fine for this PR. RDMA has no equivalent runtime recovery today -- it only falls back to TCP while the handshake/queue-pair bring-up is failing (rdma_endpoint.cpp), and an established QP error is treated as unrecoverable. So there is no parity gap this PR has to close. If the mechanism proves useful, the generalization worth doing afterwards is a transport-agnostic "a transport failure cools this peer for the next N seconds / new connections degrade to TCP" hook shared by RDMA and URMA, rather than a second process-global copy of the policy inside RDMA. That is also an argument for keeping the policy interface small and transport-neutral where it is cheap to do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
URMA can fall back to TCP during connection setup, but established failures do not guide subsequent connection attempts. A failed server SEND can close the control socket while the client immediately reconnects over URMA to the same peer.
What is changed and the side effects?
Mode changes affect new connections. Short connections can resume URMA after cooldown; established single/pooled TCP connections can continue serving RPCs. Existing v2/v3 wire formats remain compatible.
Validation
Related discussions and PRs
Check List