Skip to content

Remove awsapi leftovers - #13712

Open
winterhazel wants to merge 6 commits into
apache:mainfrom
winterhazel:remove-awsapi
Open

winterhazel wants to merge 6 commits into
apache:mainfrom
winterhazel:remove-awsapi

Conversation

@winterhazel

@winterhazel winterhazel commented Jul 27, 2026 •

Copy link
Copy Markdown
Member

Description

This PR removes a few leftovers from awsapi.

Column default_zone_id was added to account solely for the integration, and is not used anymore. API markDefaultZoneForAccount was created to set the value of this unused column.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

How Has This Been Tested?

Tests are still pending.

@codecov

codecov Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.78%. Comparing base (c5bd11a) to head (9886138).

Additional details and impacted files
@@             Coverage Diff              @@
##              main   #13712       +/-   ##
============================================
+ Coverage     3.86%   20.78%   +16.91%     
- Complexity       0    20855    +20855     
============================================
  Files          494     6052     +5558     
  Lines        42875   548172   +505297     
  Branches      8136    73231    +65095     
============================================
+ Hits          1657   113916   +112259     
- Misses       40986   420909   +379923     
- Partials       232    13347    +13115     
Flag Coverage Δ
uitests 3.86% <ø> (ø)
unittests 22.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland moved this from Backlog to Ready in CloudStack Testing Sep 1, 2026
@winterhazel
winterhazel marked this pull request as ready for review October 7, 2026 13:13
@winterhazel

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 19981

@winterhazel

Copy link
Copy Markdown
Member Author

@Damans227 @JoaoJandre I have addressed your comments. Could you re-review?

@JoaoJandre JoaoJandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@winterhazel

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20057

@RosiKyu

RosiKyu commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-17596)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 59702 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13712-t17596-kvm-ol8.zip
Smoke tests completed. 156 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_1_userdata_on_ssvm Error 3.37 test_systemvm_userdata.py

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

6 participants