Repository navigation
enable Reproducible Builds - #13937
DaanHoogland wants to merge 3 commits into
Conversation
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #13937 +/- ##
=============================================
- Coverage 20.77% 3.86% -16.91%
=============================================
Files 6053 494 -5559
Lines 548187 42875 -505312
Branches 73227 8136 -65091
=============================================
- Hits 113870 1657 -112213
+ Misses 420976 40986 -379990
+ Partials 13341 232 -13109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18932 |
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.51% |
| Branch coverage | 18.68% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
|
[SF] Trillian test result (tid-16793)
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18993 |
|
[SF] Trillian Build Failed (tid-16832) |
|
[SF] Trillian test result (tid-16842)
|
|
@nvazquez @vishesh92 @RosiKyu , repeatable builds are actually a (soft) requirement by apache. I finally got to finish this after a few years :’/ please considder this early in the cycle as well (no functional code change). |
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-shade-plugin</artifactId> | ||
| <version>3.0.0</version> |
There was a problem hiding this comment.
why do we need to remove the pinned version here?
There was a problem hiding this comment.
Not sure if we do, I inherited the PR. we can put it back, but do we need to? imnsho it should be from the parent pom anyway.
dcd56c3 to
cc62b2a
Compare
cc62b2a to
cbcc2df
Compare



Description
This PR...
overrides #6801
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?