[DaanHoogland]

Description

This PR...

Fixes: #9640

Note 1: this is usefull for smaller installations and/or installations that have a small number of clusters in comparison to the number of hosts.
Note 2: this does not affect or enable realtime rebalancing of direct agents, only attached agents are impacted.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.78%. Comparing base (f3cb957) to head (6869aff).

Files with missing lines	Patch %	Lines
.../agentlb/ClusterBasedAgentLoadBalancerPlanner.java	80.95%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #14000   +/-   ##
=========================================
  Coverage     20.78%   20.78%           
- Complexity    21928    21934    +6     
=========================================
  Files          6496     6496           
  Lines        591657   591664    +7     
  Branches      72592    72592           
=========================================
+ Hits         122956   122977   +21     
+ Misses       455356   455343   -13     
+ Partials      13345    13344    -1     

Flag	Coverage Δ
uitests	3.88% <ø> (ø)
unittests	22.09% <80.95%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🔴 Test Coverage Grade: D — Marginal

Metric	Value
Line coverage	25.89%
Branch coverage	20.23%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19968

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-17532)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 64476 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14000-t17532-kvm-ol8.zip
Smoke tests completed. 152 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestTemplateHierarchy>:setup	Error	15.19	test_accounts.py
test_vm_backup_lifecycle_with_validation	Error	131.50	test_backup_recovery_kboss.py
ContextSuite context=TestKBOSSBackupAndRecovery>:teardown	Error	138.95	test_backup_recovery_kboss.py
test_04_extract_Iso	Error	1.11	test_iso.py
test_13_retrieve_vr_default_files	Error	2.17	test_diagnostics.py
test_14_retrieve_vr_one_file	Error	2.20	test_diagnostics.py
test_15_retrieve_ssvm_default_files	Error	2.21	test_diagnostics.py
test_16_retrieve_ssvm_single_file	Error	1.15	test_diagnostics.py
test_17_retrieve_cpvm_default_files	Error	1.16	test_diagnostics.py
test_18_retrieve_cpvm_single_file	Error	1.13	test_diagnostics.py
test_05_list_volumes_isrecursive	Failure	0.07	test_list_volumes.py
test_07_list_volumes_listall	Failure	0.05	test_list_volumes.py

[RosiKyu]

@blueorangutan test

[blueorangutan]

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-17544)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 65195 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14000-t17544-kvm-ol8.zip
Smoke tests completed. 156 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_2_userdata_on_cpvm	Failure	100.31	test_systemvm_userdata.py

[RosiKyu]

@blueorangutan test

[blueorangutan]

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-17562)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 72836 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr14000-t17562-kvm-ol8.zip
Smoke tests completed. 154 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_provision_certificate	Failure	44.46	test_certauthority_root.py
test_08_arping_in_ssvm	Failure	5.36	test_diagnostics.py
test_08_upgrade_kubernetes_ha_cluster	Failure	3695.66	test_kubernetes_clusters.py