Skip to content

KVM: Support multi vlan trunk NICs - #14166

Draft
Pearl1594 wants to merge 34 commits into
mainfrom
support-multi-vlan-guestnet
Draft

Pearl1594 wants to merge 34 commits into
mainfrom
support-multi-vlan-guestnet

remove usage of internal db ids

3fc9b84
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 19, 2026 in 6m 40s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 1973 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Klx&open=AaEYA0ZipHmdrJ_o8Klx&pullRequest=14166

Check warning on line 1949 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Kln&open=AaEYA0ZipHmdrJ_o8Kln&pullRequest=14166

Check warning on line 1566 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Ki8&open=AaEYA0ZhpHmdrJ_o8Ki8&pullRequest=14166

Check warning on line 33 in engine/schema/src/main/java/com/cloud/vm/dao/NicNetworkMapDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "AllFieldsSearch" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHQjdBIFDwPvW32l&open=AaChtHQjdBIFDwPvW32l&pullRequest=14166

Check warning on line 1460 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8KiT&open=AaEYA0ZhpHmdrJ_o8KiT&pullRequest=14166

Check warning on line 1626 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kji&open=AaEYA0ZhpHmdrJ_o8Kji&pullRequest=14166

Check warning on line 257 in server/src/test/java/org/apache/cloudstack/storage/template/VnfTemplateManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0X1pHmdrJ_o8KiE&open=AaEYA0X1pHmdrJ_o8KiE&pullRequest=14166

Check warning on line 124 in plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/motion/LinstorDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAzmzpHmdrJ_o8KhL&open=AaEYAzmzpHmdrJ_o8KhL&pullRequest=14166

Check warning on line 2028 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KmC&open=AaEYA0ZipHmdrJ_o8KmC&pullRequest=14166

Check warning on line 494 in server/src/test/java/com/cloud/deploy/DeploymentPlanningManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0qnpHmdrJ_o8KpT&open=AaEYA0qnpHmdrJ_o8KpT&pullRequest=14166

Check warning on line 1765 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Kkn&open=AaEYA0ZipHmdrJ_o8Kkn&pullRequest=14166

Check warning on line 1652 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kjx&open=AaEYA0ZhpHmdrJ_o8Kjx&pullRequest=14166

Check warning on line 1496 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kil&open=AaEYA0ZhpHmdrJ_o8Kil&pullRequest=14166

Check warning on line 1618 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_vlanTrunkTags" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCq828-t_SkqufYqmdL&open=AaCq828-t_SkqufYqmdL&pullRequest=14166

Check warning on line 127 in server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_nicNetworkMapDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAzuApHmdrJ_o8KhP&open=AaEYAzuApHmdrJ_o8KhP&pullRequest=14166

Check warning on line 2186 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8KnG&open=AaEYA0ZipHmdrJ_o8KnG&pullRequest=14166

Check warning on line 1620 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kje&open=AaEYA0ZhpHmdrJ_o8Kje&pullRequest=14166

Check warning on line 1630 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZhpHmdrJ_o8Kjk&open=AaEYA0ZhpHmdrJ_o8Kjk&pullRequest=14166

Check failure on line 374 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAzfQpHmdrJ_o8KhI&open=AaEYAzfQpHmdrJ_o8KhI&pullRequest=14166

Check warning on line 2246 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Kno&open=AaEYA0ZipHmdrJ_o8Kno&pullRequest=14166

Check warning on line 2130 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Kmi&open=AaEYA0ZipHmdrJ_o8Kmi&pullRequest=14166

Check warning on line 230 in server/src/main/java/com/cloud/network/rules/RulesManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "guestNic" local variable.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAz6kpHmdrJ_o8KhU&open=AaEYAz6kpHmdrJ_o8KhU&pullRequest=14166

Check failure on line 34 in engine/schema/src/main/java/com/cloud/event/UsageEventVO.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYAypFpHmdrJ_o8KgR&open=AaEYAypFpHmdrJ_o8KgR&pullRequest=14166

Check warning on line 1184 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'com.cloud.exception.ResourceUnavailableException', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0AKpHmdrJ_o8Kh3&open=AaEYA0AKpHmdrJ_o8Kh3&pullRequest=14166

Check warning on line 2292 in server/src/test/java/com/cloud/network/NetworkServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaEYA0ZipHmdrJ_o8Kn0&open=AaEYA0ZipHmdrJ_o8Kn0&pullRequest=14166