Skip to content

package: Add missing openssl and decompression utilities to KVM agent dependencies - #14307

Open
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:24-package-add-openssl
Open

weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:24-package-add-openssl

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

Add bzip2, gzip, unzip, and openssl as explicit dependencies for the KVM agent. These utilities are required for:

  • Template decompression (bunzip2 for .bz2 files, gzip for .gz, unzip for .zip)
  • SSL/TLS operations
  • Direct download template handling on Ceph/RBD storage

Fixes direct download failures when template files are compressed (e.g. .qcow2.bz2).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@weizhouapache
weizhouapache requested a review from NuxRo October 5, 2026 08:58
@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.21%. Comparing base (f03cffc) to head (265fe9d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #14307   +/-   ##
=========================================
  Coverage     20.21%   20.21%           
- Complexity    20747    20750    +3     
=========================================
  Files          6426     6426           
  Lines        580181   580181           
  Branches      71033    71033           
=========================================
+ Hits         117282   117288    +6     
+ Misses       450184   450180    -4     
+ Partials      12715    12713    -2     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 21.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache added a commit to shapeblue/Trillian that referenced this pull request Oct 8, 2026
Match the KVM agent dependencies added in apache/cloudstack#14307:
openssl, bzip2, gzip and unzip are needed for template decompression
(.bz2/.gz/.zip) and direct download handling. Install them via apt on
Debian/Ubuntu and dnf on CentOS 8/EL9.
… dependencies

Add bzip2, gzip, unzip, and openssl as explicit dependencies for the KVM agent.
These utilities are required for:
- Template decompression (bunzip2 for .bz2 files, gzip for .gz, unzip for .zip)
- SSL/TLS operations
- Direct download template handling on Ceph/RBD storage

Fixes direct download failures when template files are compressed (e.g. .qcow2.bz2).
@weizhouapache
weizhouapache force-pushed the 24-package-add-openssl branch from 7d69608 to 265fe9d Compare October 8, 2026 19:26
@weizhouapache
weizhouapache marked this pull request as ready for review October 8, 2026 19:26
Copilot AI balanced review requested due to automatic review settings October 8, 2026 19:26
@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The agent still lacks explicit file and xz dependencies required by its supported extraction path.

3 open findings
What changed in this PR

Adds explicit SSL and decompression runtime dependencies to KVM agent packages.

Changes:

  • Adds OpenSSL, bzip2, gzip, and unzip dependencies across supported distributions.
File Description
packaging/​suse15/​cloud.spec Updates SUSE agent dependencies.
packaging/​el8/​cloud.spec Updates EL8 agent dependencies.
debian/​control Updates Debian agent dependencies.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread debian/control
Package: cloudstack-agent
Architecture: all
Depends: ${python:Depends}, ${python3:Depends}, openjdk-17-jre-headless | java17-runtime-headless | java17-runtime | zulu-17, cloudstack-common (= ${source:Version}), lsb-base (>= 9), openssh-client, qemu-kvm (>= 2.5) | qemu-system-x86 (>= 5.2), libvirt-bin (>= 1.3) | libvirt-daemon-system (>= 3.0), iproute2, ebtables, vlan, ipset, python3-libvirt, ethtool, iptables, cryptsetup, rng-tools, rsync, ovmf, swtpm, lsb-release, ufw, apparmor, cpu-checker, libvirt-daemon-driver-storage-rbd, sysstat, python3-libnbd, socat
Depends: ${python:Depends}, ${python3:Depends}, openjdk-17-jre-headless | java17-runtime-headless | java17-runtime | zulu-17, cloudstack-common (= ${source:Version}), lsb-base (>= 9), openssh-client, qemu-kvm (>= 2.5) | qemu-system-x86 (>= 5.2), libvirt-bin (>= 1.3) | libvirt-daemon-system (>= 3.0), iproute2, ebtables, vlan, ipset, python3-libvirt, ethtool, iptables, cryptsetup, rng-tools, rsync, ovmf, swtpm, lsb-release, ufw, apparmor, cpu-checker, libvirt-daemon-driver-storage-rbd, sysstat, python3-libnbd, socat, openssl, bzip2, gzip, unzip
Comment thread packaging/el8/cloud.spec
Comment on lines +132 to +135
Requires: openssl
Requires: bzip2
Requires: gzip
Requires: unzip
Comment on lines +130 to +133
Requires: openssl
Requires: bzip2
Requires: gzip
Requires: unzip
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19489

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants