Repository navigation
allow EC private keys when uploading a custom certificate - #14317
Conversation
|
@blueorangutan package |
|
@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14317 +/- ##
=========================================
Coverage 19.91% 19.91%
- Complexity 20198 20204 +6
=========================================
Files 6373 6373
Lines 577230 577236 +6
Branches 70696 70697 +1
=========================================
+ Hits 114936 114967 +31
+ Misses 449736 449701 -35
- Partials 12558 12568 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19423 |
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
not tested yet
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-17099)
|
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19844 |
|
@blueorangutan test |
RosiKyu
left a comment
There was a problem hiding this comment.
LGTM
Tested on a KVM env (mgmt + 2 EL9 KVM hosts), baseline on a main-based build first, then the PR build (24.0.0-shapeblue22384).
- Before: EC prime256v1, EC secp384r1 and DSA certificates all fail with 431, log "Invalid RSA private key". RSA uploads.
- After: EC P-256, EC P-384 and DSA upload, RSA still uploads.
- Bad keys still rejected (431): EC key in SEC1 format (BEGIN EC PRIVATE KEY) and a garbage key; the log now says "Private key is not one of the supported types: RSA, EC, DSA".
- End to end: consoleproxy.sslEnabled=true, consoleproxy.url.domain=*.ec256.qa.test, EC cert uploaded, console proxy restarted: port 443 serves the uploaded EC certificate (same fingerprint, P-256), cipher ECDHE-ECDSA-AES256-GCM-SHA384.
Fixes #14239
Uploading a custom certificate with uploadCustomCertificate fails when the certificate uses an elliptic curve key. The private key was always read as RSA, so an EC key was rejected and the whole upload failed. This tries RSA first, then EC, then DSA, so EC certificates upload the same way RSA ones do. RSA keys are read exactly as before.
Test:
Make an EC (prime256v1) certificate and key, and an RSA one for comparison, then upload each with CloudMonkey.
Before: the EC upload fails. The RSA one passes the check.
After: both EC and RSA upload. EC is job-38, RSA is job-39.