Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14460 +/- ##
=========================================
Coverage 18.07% 18.07%
- Complexity 16357 16361 +4
=========================================
Files 5937 5937
Lines 537029 537058 +29
Branches 65833 65836 +3
=========================================
+ Hits 97043 97054 +11
- Misses 428901 428919 +18
Partials 11085 11085
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| ActionEventUtils.onActionEvent(User.UID_SYSTEM, Account.ACCOUNT_ID_SYSTEM, vm.getDomainId(), | ||
| EventTypes.EVENT_VM_START, "Out of band VM power on", vm.getId(), getApiCommandResourceTypeForVm(vm).toString()); | ||
| logger.info("VM {} is sync-ed to at Running state according to power-on report from hypervisor.", vm.getInstanceName()); | ||
| reconcileNicsForRunningVm(vm); |
There was a problem hiding this comment.
why do we need it in the stopped||stopping block? if the VM never reports as running again we have a spare nic in our nic count. should it be added to the start block instead.
There was a problem hiding this comment.
when a running vm is reported as stopped, cloudstack will send a command to force-stop it (I guess it is to ensure the vm is stopped) , and release the nic when done.
as far as I know, nics_count is not used any more to determine if the network need to be shutdown. the goal of this PR is to restore the nic state, not nics_count. PR title should be updated.
There was a problem hiding this comment.
@Pearl1594 do you agree? can you update the PR title aprpriately?
Description
This PR fixes: #14177
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?