Repository navigation
Upgrade brotli4j to 1.24.0 for CVE-2026-111497 - #903
Merged
Merged
Conversation
Member
|
Cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
CVE-2026-111497 is an out-of-bounds write in the Google Brotli decoder, fixed in Brotli 1.2.1. HttpClient 5 decompresses
Content-Encoding: brresponses through the optional brotli4j integration (BrotliDecompressingEntity/InflatingBrotliDataConsumer). The current brotli4j 1.23.0 bundles Brotli 1.2.0, so a malicious or compromised origin can reach the vulnerable decoder.brotli4j 1.24.0 upgrades the bundled native decoder to Brotli 1.2.1:
Change
brotli4j.versionproperty from 1.23.0 to 1.24.0.No API or behavior changes.
Testing
Results:
DeflatingBrotliEntityProducerTest: 1 passedInflatingBrotliDataConsumerTest: 4 passedBrotli4jRuntimeTest: 1 passedTotal: 6 tests, 0 failures, 0 errors.
I could not find an existing HTTPCLIENT JIRA for this dependency bump; happy to file one if required before review.