Repository navigation
Conversation
* test/clients/h2ws.c (main): Use int for the getopt() return value; with unsigned char (e.g. on aarch64) the -1 terminator is never matched, so every invocation failed with "invalid option". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* .github/workflows/linux.yml: Add a "Python pytest test suites, 64-bit ARM" job to the matrix, as the existing pytest job but on the ubuntu-24.04-arm runner. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Oct 16, 2026
* test/clients/h2ws.c (main): Use int for the getopt() return value; with unsigned char (e.g. on aarch64) the -1 terminator is never matched, so every invocation failed with "invalid option". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> GitHub: PR #855 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1939168 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Linux matrix job running the full pytest suite (
make check-all-pytest, including the md/pebble tests) on theubuntu-24.04-armrunner. The existing ARM matrix entry only builds and runs the Perl framework, so the pytest suites had never run on aarch64.Doing so exposed a bug in the h2ws test client:
main()heldgetopt()'s return value in achar, and wherecharis unsigned (as on aarch64) the-1terminator never matches, so every invocation exited with "invalid option" — failing all 31 tests inmodules/http2/test_800_websockets.py. Withint, the full suite passes on the ARM runner. No other client under test/clients/ has the same pattern.🤖 Generated with Claude Code