Repository navigation
chore: upgrade the project version to 1.8.0 - #3282
Conversation
- align project versions and current release examples - resolve published parent POMs outside the source tree - pin Helm application defaults while retaining image overrides - verify release and protocol versions in existing smoke tests
- preserve published image tags and download examples - mark release reference updates as post-release TODOs - reuse sed and jq without adding Python prerequisites - reject missing expected protocol versions in smoke tests
- describe appVersion as source release metadata - retain published image references until release - explain precedence of explicit image tags
- preserve the existing executable bit - keep direct CI script invocation working - retain the release version assertions
- use reactor Commons with the legacy cluster Client - update application labels in Helm snapshots - assert metadata explicitly despite the snapshot plugin defect - keep unpublished image references on existing tags
- drop legacy Commons Configuration and Javassist JAR entries - align release LICENSE with the selected reactor dependencies - retain the existing third-party versions and license texts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3282 +/- ##
============================================
- Coverage 41.18% 37.51% -3.67%
+ Complexity 6771 4878 -1893
============================================
Files 766 573 -193
Lines 66086 53125 -12961
Branches 8773 7250 -1523
============================================
- Hits 27218 19932 -7286
+ Misses 35819 30899 -4920
+ Partials 3049 2294 -755 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The Maven revision, VersionInBash, the root flatten plugin and the exact-version smoke checks line up and pass in CI. Setting the Helm appVersion to 1.8.0 before any 1.8.0 image exists means an empty image tag now renders an image reference that cannot be pulled, and every pod gets a 1.8.0 version label while it runs latest. Two smaller gaps: license files for the two removed jars stay in the release docs, and several 1.7.0 references outside the files you marked have no post-release TODO. Evidence: full diff of 5854beb against merge-base d9abcd4 (18 files, 6 commits). _helpers.tpl:1001 renders default .appVersion $img.tag, and the PR's own image_digest_test.yaml asserts hugegraph/pd:1.8.0 for an empty tag. Docker Hub returns 404 for hugegraph/{pd,store,server}:1.8.0 and 200 for 1.7.0. git grep at the head for 1.7.0 and for the removed jar names. Hard-coded version consumers (CoreVersion, CommonVersion, RpcVersion, ApiVersion) read version.properties or the manifest. The /versions checks ran and passed in docker-build and build-server-riscv64. Latest-head CI is not green: affected-module-tests fails because commons / Commons tests (Java 17) failed in hugegraph-rpc ServerClientTest (bind failed, address already in use; this looks like a flaky port clash rather than this diff), and the advisory dependency-review flags spring-webmvc 5.3.27 in hg-pd-dist (critical). That looks pre-existing and shows up only because the base has no dependency snapshot.
- validate legal random routing and always clean test RPC resources - retain Helm latest metadata until release images are published - preserve published README versions and mark post-release updates - align build-directory comments and remove orphan license texts
- preserve master shared foundation and build fixes - retain the 1.8.0 version checks and publication TODOs - reuse master dependency management and release inventories
- declare reactor Commons on the cluster test leaf module - inherit revision from existing dependency management - include local Common in Maven -am builds
- retain real Memory suites and their required summary - document the two stable required check names - align inventory and licenses with the observed runtime dependencies
- scope Commons installation and maintenance inputs - verify graph writes and queries on current PR images - honor Struct staging and retire the Commons alias - bound supported jobs and remove stale TP exceptions - document deferred CI policy and retry work
- verify checkout against the event merge SHA - preserve current PR head and source checks - record the actual tested base from merge parents - cover base advancement and reject incorrect merges
- select Docker checks for the Server parent POM - run TP branch contract checks from PD/Store CI - test parent POM selection without new dependencies - clarify dedicated source and target branch triggers
Purpose of the PR
Build and report HugeGraph 1.8.0 instead of 1.7.0. Preserve Java 17, Commons/RPC Java 11 bytecode, independent REST protocol versions and the current TinkerPop adaptation.
Published download links, image tags and README version badges stay on available releases. TODOs mark their post-release update; this PR does not publish artifacts or images.
Main Changes
-ambuilds it locally; inherit its version from master’s dependency management and retain master’s refreshed legal inventory.check-license,Server memory tests).Verifying these changes
Changes originate in Org PR #275 and use the same branch and commits here.
Dependency Review passes on the current commit without lowering security thresholds, exempting vulnerabilities or upgrading Spring. The related snapshot/security investigation is tracked in Issue #3283.
TinkerPop suites remain limited to
release-,test-andtinkerpop-branches. Remove obsolete task-branch conditions and the temporary skip; this version-only upgrade branch does not run long TP suites. Broader CI changes are recorded indocs/ci.mdfor follow-up. Toolchain source changes, downstream qualification, full migration/rollback and formal release are outside this PR.