Skip to content

Avro: read a file without avro.codec as uncompressed #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 1 commit into from
Nov 9, 2026
Merged

Avro: read a file without avro.codec as uncompressed #4296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pyiceberg/avro/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,10 @@ def compression_codec(self) -> type[Codec] | None:
"""Get the file's compression codec algorithm from the file's metadata.

In the case of a null codec, we return a None indicating that we
don't need to compress/decompress.
don't need to compress/decompress. A file without the avro.codec
entry is uncompressed: the Avro specification makes "null" the default.
"""
from pyiceberg.table import TableProperties

codec_name = self.meta.get(AVRO_CODEC_KEY, TableProperties.WRITE_AVRO_COMPRESSION_DEFAULT)
codec_name = self.meta.get(AVRO_CODEC_KEY, "null")

@kevinjqliu kevinjqliu Nov 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

reference:
https://avro.apache.org/docs/1.12.0/specification/#null

Image

if codec_name not in KNOWN_CODECS:
raise ValueError(f"Unsupported codec: {codec_name}")

Expand Down
6 changes: 6 additions & 0 deletions tests/avro/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ def get_null_compressor() -> None:
assert header.compression_codec() is None


def test_missing_codec_is_null() -> None:
# the Avro specification: a file without avro.codec is uncompressed (iceberg-rust writes such manifests)
header = AvroFileHeader(bytes(0), {}, bytes(16))
assert header.compression_codec() is None


def test_unknown_codec() -> None:
header = AvroFileHeader(bytes(0), {"avro.codec": "unknown"}, bytes(16))

Expand Down
Loading