Repository navigation
REST: Use the standard User-Agent format - #4330
Merged
Merged
Conversation
Send pyiceberg/<version> (<python implementation> <python version>), for example pyiceberg/0.11.0 (cpython 3.11.4), the format recommended by the REST catalog spec (apache/iceberg#17727). Co-authored-by: Isaac <no-reply@databricks.com>
rambleraptor
approved these changes
Nov 10, 2026
rambleraptor
left a comment
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
Love this! Thanks for driving this forward
Fokko
approved these changes
Nov 11, 2026
Fokko
enabled auto-merge
November 11, 2026 14:32
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
approved these changes
Nov 11, 2026
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I pushed a change to use for loop instead of parameterized in tests (9a3452b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Iceberg REST catalog spec now recommends a standard User-Agent format (apache/iceberg#17727). pyiceberg now sends
pyiceberg/<version> (<python implementation> <python version>), for examplepyiceberg/0.11.0 (cpython 3.11.4), instead ofPyIceberg/<version>. TheX-Client-Versionheader is unchanged.Are these changes tested?
Yes. The expected headers in
tests/catalog/test_rest.pyare updated, andtest_user_agent_headerchecks the format for CPython and PyPy.Are there any user-facing changes?
The
User-Agentheader sent to REST catalogs changes fromPyIceberg/<version>to the format above.This pull request and its description were written by Isaac.