[Anurag-S1ngh]

Closes #3836

Rationale for this change

RestCatalog.drop_table passed the purge_requested boolean directly into the requests query params, and requests serializes True as "True". The REST catalog spec defines purgeRequested as a boolean query parameter, so spec-compliant servers reject the capitalized form with 400 Bad Request (for example OSS Tables, which only supports dropping tables with purge enabled).

This sends the spec-compliant lowercase "true" / "false" explicitly, matching how the other query parameters in the REST client are serialized. purge_table goes through the same code path.

Are these changes tested?

Two regression tests in tests/catalog/test_rest.py assert the exact query string on the wire for purge_requested=True and for the default False. The assertion is on the raw request URL rather than request.qs because requests_mock lowercases parsed query values, which would hide the bug.

tests/catalog/test_rest.py passes (192 tests) and prek run is clean on the changed files (ruff, ruff-format, mypy, codespell).

Are there any user-facing changes?

RestCatalog.drop_table and purge_table now serialize purgeRequested as a lowercase boolean, fixing 400 responses from servers that validate the parameter strictly.

[kevinjqliu]

LGTM

good catch.

heres the rest spec reference: https://github.com/apache/iceberg/blob/014b3ce5ffbf7c1c51dabb144f4d94e45addcd88/open-api/rest-catalog-open-api.yaml#L1298-L1304

[kevinjqliu]

i pushed a change to consolidate the tests based on my agent's suggestion 😄

01002b4

[rambleraptor]

I had approved #3837 which it looks like was closed by the stale bot. This looks like the equivalent. Thanks for doing this!