Repository navigation
HDDS-16677. Support create MPU key with StoragePolicy - #11626
Conversation
|
PTAL @devmadhuu , @priyeshkaratha , @Gargi-jais11 and @xichen01 ! |
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @anuragp010 for the patch. Can you pls check the review comments ?
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @anuragp010 for working on this. Left few comments
rakeshadr
left a comment
There was a problem hiding this comment.
Thanks @anuragp010 for the contribution. Added a few comments.
|
General Comment:- @anuragp010. Thanks for adding UT cases. |
|
Thanks @rakeshadr for the review !
The following tests in the PR run on MiniOzoneCluster:
|
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @anuragp010 for updating the patch, LGTM, just few nits. Pls take care.
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @anuragp010 for updating the patch and addressing the review comments. Largely looks good to me, except this below scenario. Can you check if this is possible ?
- The cluster is upgraded and finalized. An administrator sets the bucket policy to COLD.
- An old client starts an upload without sending any storage-policy field.
- OM inherits COLD from the bucket and saves it on the upload.
- While that upload is running, the administrator changes the bucket to WARM.
- The same old client requests another block, again without a policy field.
- OM currently resolves that missing field from the bucket’s current WARM policy, instead of the upload’s saved COLD policy.
Hi @devmadhuu , as discussed, yes this is possible. Verified the same. This behaviour is possible in the normal createKey too and will use HDDS-17374 to handle this scenario. |
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @anuragp010 for addressing all review comments. LGTM +1. Will review your follow up JIRA PRs as mentioned in this PR review discussion. This PR change is good.
|
Thanks @devmadhuu ! |
rakeshadr
left a comment
There was a problem hiding this comment.
@anuragp010 added one more comment. Thanks for the continuous effort!
rakeshadr
left a comment
There was a problem hiding this comment.
+1 LGTM. Thanks @anuragp010 for working on this.
|
Thanks @rakeshadr ! |
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @anuragp010 for updating the PR.
LGTM, +1
|
Thanks @anuragp010 for the patch. Thanks @Gargi-jais11 @rakeshadr for the review. |
|
Thanks @devmadhuu , @Gargi-jais11 , @rakeshadr for the review ! |
Co-authored-by: https://github.com/xichen01
What changes were proposed in this pull request?
MPUKeys do not support Storage Policy. This PR adds support for passing aStoragePolicyduring the initiateMPU phase and then reuses thisStoragePolicyfor every part uploaded. To ensure upgrade semantics are followed and all OMs, during an upgrade, apply the MPU log consistently, StoragePolicy on an MPU key is ignored when the cluster is not finalized.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16677
How was this patch tested?
Generated with Claude Code: Sonnet-5.5