Skip to content

[core] Fallback and chain queries fail when unreferenced columns are denied - #10725

Merged
JingsongLi merged 1 commit into
apache:masterfrom
taoran92:fix/query-auth-internal-scan-projection
Oct 26, 2026
Merged

JingsongLi merged 1 commit into
apache:masterfrom
taoran92:fix/query-auth-internal-scan-projection

Conversation

@taoran92

@taoran92 taoran92 commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Purpose

Closes #10722.

Pass the requested projection to partition-listing and chain streaming-start scans. Include user-filter columns in newly created scans' read types so WHERE operands remain authorized even when they are not projected.

Add withInternalPartitionFilter for execution-only partition selection, such as fallback gaps and chain anchors. It replaces the physical filter while preserving user partition-filter authorization fields; ordinary withPartitionFilter would incorrectly require access to internal partition keys. Forward this behavior through data-evolution scans.

Tests

  • FallbackReadFileStoreTableTest and ChainTableFileStoreTableTest: all tests passed.

@taoran92
taoran92 marked this pull request as ready for review October 21, 2026 16:23
@taoran92
taoran92 force-pushed the fix/query-auth-internal-scan-projection branch 2 times, most recently from a945f13 to 9badcbf Compare October 22, 2026 06:21
@taoran92 taoran92 changed the title [core] Avoid requiring unreferenced columns in fallback and chain queries [core] Fallback and chain queries require access to unreferenced columns Oct 22, 2026
@taoran92
taoran92 force-pushed the fix/query-auth-internal-scan-projection branch from 9badcbf to cb0c8e0 Compare October 23, 2026 06:55
@taoran92 taoran92 changed the title [core] Fallback and chain queries require access to unreferenced columns [core] Fallback and chain queries fail when unreferenced columns are denied Oct 23, 2026
@taoran92

Copy link
Copy Markdown
Member Author

Hi @JingsongLi Could you please review this PR? This fixes authorization errors blocking valid fallback/chain table queries.

CI failures seems unrelated with this commit, it would also help if you could rerun the failed CI checks. Thanks.

@Akash3121 Akash3121 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JingsongLi JingsongLi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi
JingsongLi merged commit 8ef3e0c into apache:master Oct 26, 2026
15 of 18 checks passed
@taoran92
taoran92 deleted the fix/query-auth-internal-scan-projection branch October 27, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fallback and chain queries fail when unreferenced columns are denied

3 participants