Repository navigation
[core] Trim field names in changelog-producer.row-deduplicate-ignore-fields - #10763
Merged
JingsongLi merged 1 commit intoOct 26, 2026
Merged
Conversation
…fields CoreOptions#changelogRowDeduplicateIgnoreFields split the option value on "," without trimming, so 'a, b' yielded " b" and field b was not ignored by the row-deduplicate equaliser. Trim each name, as sequenceField() does since apache#6651. Generated-by: Claude Code
Akash3121
approved these changes
Oct 25, 2026
Akash3121
left a comment
Akash3121
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Trimming at the CoreOptions boundary fixes the exact-name mismatch before the ignore list reaches ValueEqualiserSupplier, and it follows the existing sequenceField() convention. The unit test covers whitespace normalization and the scanner test verifies the end-to-end lookup changelog behavior.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #10762
CoreOptions#changelogRowDeduplicateIgnoreFieldssplit the value on,without trimming, so'a, b'produced" b"andbwas not ignored.changelog-producer.row-deduplicate = true, an update that changes onlybstill emitted-U/+U, with no error or warning.sequenceField()after [core] Fix sequence.field parsing to trim spaces #6651.Tests
CoreOptionsTest#testChangelogRowDeduplicateIgnoreFieldsTrim, mirroringtestSequenceFieldTrim.IncrementalDeltaStartingScannerTest#testRowDeduplicateIgnoreFieldsWithSpaces: lookup changelog producer,'a, b', update changing onlyb; the changelog is empty. Before the fix it fails withExpecting empty but was: ["-U 1|10|100", "+U 1|10|500"].mvn -pl paimon-api,paimon-core test -Dtest=CoreOptionsTest,IncrementalDeltaStartingScannerTest: BUILD SUCCESS, 0 failures (22/22 and 5/5).mvn spotless:checkpassed.