Repository navigation
Conversation
taoran92
marked this pull request as ready for review
October 23, 2026 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #10765.
When
sink.writer-memoryconfigures an explicit writer slot sharing group, the group currently requests zero managed memory. Changingsink.managed.writer-buffer-memoryonly changes the operator's allocation weight, so users cannot request heap and managed resources independently.Add the optional
sink.writer-managed-memoryproperty for ordinary writers and the CDC combined sink. It requiressink.writer-memoryand a positive value, and sets the managed resource request for each shared slot of the writer group. For example, a writer group can request 512 MiB of task heap and 128 MiB of managed memory while retaining an operator weight of 256.The option does not enable the managed allocator or change allocation weights. Existing behavior when the option is absent, downstream slot sharing, and explicit committer resources are preserved. Update the configuration guide and generated option reference to explain these boundaries.
Tests
WriterManagedMemoryTestFlinkCdcMultiTableSinkTestFlinkSinkTestWriterChainingStrategyTestThe tests cover StreamGraph and JobGraph resources, allocator enabled and disabled, configuration validation, legacy behavior, and explicit committer resources. All tests passed.