Repository navigation
GH-3896: Remove AccessController.doPrivileged usage - #3902
Merged
Merged
Conversation
AccessController and PrivilegedAction are deprecated for removal since JDK 17 (JEP 411), and without a SecurityManager doPrivileged just runs the action. Now that the minimum JDK is 17, call the code directly: - DynMethods/DynConstructors: call setAccessible(true) directly and drop the private MakeAccessible helpers. InaccessibleObjectException is now caught next to SecurityException, so an impl that can't be made accessible is still skipped instead of failing the builder. - parquet-cli BaseCommand: build the URLClassLoader directly in a small private helper and delete the GetClassLoader PrivilegedAction. Co-authored-by: Isaac <no-reply@databricks.com>
wgtmac
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
AccessControllerandPrivilegedActionare deprecated for removal since JDK 17 (JEP 411). Without a SecurityManager,doPrivilegedjust runs the action, and the minimum JDK is now 17.What changes are included in this PR?
DynMethods/DynConstructors: callsetAccessible(true)directly and drop the privateMakeAccessiblehelpers.InaccessibleObjectExceptionis caught next toSecurityException, so an implementation that can't be made accessible is still skipped instead of failing the builder.BaseCommand: build theURLClassLoaderdirectly and delete theGetClassLoaderPrivilegedAction.Are these changes tested?
Covered by the existing tests:
TestDynMethods,TestDynConstructorsand the parquet-cli test suite.Are there any user-facing changes?
No.
Closes #3896
This pull request and its description were written by Isaac.