Repository navigation
[SYSTEMDS-3991] Prepare PTB-XL ECG dataset for Scuro - #2638
Open
shieru1214 wants to merge 2 commits into
Open
shieru1214 wants to merge 2 commits into
shieru1214 wants to merge 2 commits into
Conversation
Assisted-by: AI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes format checks and error messages in
TimeseriesLoaderand adds tests for them.TimeseriesLoader fixes
matandhdf5from the supported formats because they are not implemented yet, and addcsvto the format check.wfdbonly when needed and gives an installation hint if the package is missing. This does not addfile_format="wfdb"support yet.Tests
I enabled
test_timeseries_loader_loads_all_instancesandtest_timeseries_loader_stats. They now use["x", "y"]as signal names. The data generator writes 10 samples with 2 signals, so the stats test can checkmax_lengthandnum_signals.The new tests check that the missing filename appears in the error, that
mat,hdf5, and unknown formats are rejected, and that selectingyfrom a two-column CSV returns exactly the second column. I also added a test for the installation hint whenwfdbis missing.