Skip to content

[SYSTEMDS-3991] Prepare PTB-XL ECG dataset for Scuro - #2638

Open
shieru1214 wants to merge 2 commits into
apache:mainfrom
shieru1214:scuro-ptbxl
Open

shieru1214 wants to merge 2 commits into
apache:mainfrom
shieru1214:scuro-ptbxl

Conversation

@shieru1214

Copy link
Copy Markdown
Contributor

This change fixes format checks and error messages in TimeseriesLoader and adds tests for them.

TimeseriesLoader fixes

  • Remove mat and hdf5 from the supported formats because they are not implemented yet, and add csv to the format check.
  • Make the “file not found” error show the actual filename.
  • Add a helper that imports wfdb only when needed and gives an installation hint if the package is missing. This does not add file_format="wfdb" support yet.

Tests

I enabled test_timeseries_loader_loads_all_instances and test_timeseries_loader_stats. They now use ["x", "y"] as signal names. The data generator writes 10 samples with 2 signals, so the stats test can check max_length and num_signals.

The new tests check that the missing filename appears in the error, that mat, hdf5, and unknown formats are rejected, and that selecting y from a two-column CSV returns exactly the second column. I also added a test for the installation hint when wfdb is missing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant