Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/actions-lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ concurrency:
env:
ACTIONLINT_VERSION: 1.7.12
SHELLCHECK_VERSION: v0.11.0
ZIZMOR_VERSION: 1.30.1
ZIZMOR_VERSION: 1.32.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a zizmor version the pinned action recognizes

The zizmor check reports Unknown version: 1.32.0 for this input, so the pinned zizmor-action fails instead of running its audit. Please use a version supported by the action or update the action alongside this version bump.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/actions-lint.yaml
Line: 29

Comment:
**Use a zizmor version the pinned action recognizes**

The zizmor check reports `Unknown version: 1.32.0` for this input, so the pinned `zizmor-action` fails instead of running its audit. Please use a version supported by the action or update the action alongside this version bump.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟠 Major · bug · Reply if this doesn't apply.


jobs:
actionlint:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/e2e-nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ permissions:
contents: read

env:
GATEWAY_API_VERSION: v1.6.2
TRAEFIK_CHART_VERSION: 41.6.1
GATEWAY_API_VERSION: v1.7.0
TRAEFIK_CHART_VERSION: 41.7.1

jobs:
functions:
Expand All @@ -29,7 +29,7 @@ jobs:
persist-credentials: false
- uses: azure/setup-helm@9bc31f4ebc9c6b171d7bfbaa5d006ae7abdb4310 # v5.0.1
with:
version: v4.3.0
version: v4.3.2
- uses: helm/kind-action@06c1ae10762d3b9c1644e7fe69596ae519e015a2 # v1.15.0
with:
cluster_name: appwrite
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
persist-credentials: false
- uses: azure/setup-helm@9bc31f4ebc9c6b171d7bfbaa5d006ae7abdb4310 # v5.0.1
with:
version: v4.3.0
version: v4.3.2
- name: Install kubeconform
run: |
curl -fsSL "https://github.com/yannh/kubeconform/releases/download/${KUBECONFORM_VERSION}/kubeconform-linux-amd64.tar.gz" \
Expand All @@ -144,7 +144,7 @@ jobs:
persist-credentials: false
- uses: azure/setup-helm@9bc31f4ebc9c6b171d7bfbaa5d006ae7abdb4310 # v5.0.1
with:
version: v4.3.0
version: v4.3.2
- name: Install helm-docs and helm-values-schema-json
run: |
curl -fsSL "https://github.com/norwoodj/helm-docs/releases/download/v${HELM_DOCS_VERSION}/helm-docs_${HELM_DOCS_VERSION}_Linux_x86_64.tar.gz" \
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ env:
REGISTRY: ghcr.io
REPOSITORY: ${{ github.repository_owner }}/charts
CHART: appwrite
COSIGN_VERSION: v3.1.3
ORAS_VERSION: 1.3.4
COSIGN_VERSION: v3.1.4
ORAS_VERSION: 1.3.6
# The signer docs/security.md tells users to verify against.
CERT_IDENTITY: https://github.com/${{ github.repository }}/.github/workflows/release.yaml@refs/heads/main
CERT_OIDC_ISSUER: https://token.actions.githubusercontent.com
Expand All @@ -53,7 +53,7 @@ jobs:
persist-credentials: false
- uses: azure/setup-helm@9bc31f4ebc9c6b171d7bfbaa5d006ae7abdb4310 # v5.0.1
with:
version: v4.3.0
version: v4.3.2

- name: Read the chart version
id: chart
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/renovate-generate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
persist-credentials: false
- uses: azure/setup-helm@9bc31f4ebc9c6b171d7bfbaa5d006ae7abdb4310 # v5.0.1
with:
version: v4.3.0
version: v4.3.2
- name: Install helm-docs and helm-values-schema-json
run: |
curl -fsSL "https://github.com/norwoodj/helm-docs/releases/download/v${HELM_DOCS_VERSION}/helm-docs_${HELM_DOCS_VERSION}_Linux_x86_64.tar.gz" \
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/security-scan.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ permissions:

env:
# Run from the image, pinned by digest, rather than an installer action.
TRIVY_IMAGE: docker.io/aquasec/trivy:0.75.0@sha256:af6acf9a6b85dfe389a1941505c0ce9efef52a4719635e1a962f022a3d855daa
TRIVY_IMAGE: docker.io/aquasec/trivy:0.76.2@sha256:8f6bb947dbc528902e11f2f5be52f7b519f6a39d5d148f41166f2040499768fb

jobs:
prepare:
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
persist-credentials: false
- uses: azure/setup-helm@9bc31f4ebc9c6b171d7bfbaa5d006ae7abdb4310 # v5.0.1
with:
version: v4.3.0
version: v4.3.2
- name: Render every ci/ scenario
run: |
mkdir -p rendered
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ permissions:
contents: read

env:
GATEWAY_API_VERSION: v1.6.2
TRAEFIK_CHART_VERSION: 41.6.1
GATEWAY_API_VERSION: v1.7.0
TRAEFIK_CHART_VERSION: 41.7.1

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
persist-credentials: false
- uses: azure/setup-helm@9bc31f4ebc9c6b171d7bfbaa5d006ae7abdb4310 # v5.0.1
with:
version: v4.3.0
version: v4.3.2
- uses: helm/kind-action@06c1ae10762d3b9c1644e7fe69596ae519e015a2 # v1.15.0
with:
cluster_name: appwrite
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ KIND_CLUSTER ?= appwrite
VALUES ?= $(CHART)/ci/default-values.yaml
HELM_UNITTEST ?= v1.2.1
HELM_SCHEMA ?= v2.6.0
ZIZMOR ?= 1.30.1
ZIZMOR ?= 1.32.0
CRD_SCHEMAS ?= https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/{{.Group}}/{{.ResourceKind}}_{{.ResourceAPIVersion}}.json
# Values files in examples/, each a space-free list of files joined with "+"
# (applied in order with -f). Overlays are checked on top of a base file.
Expand Down
10 changes: 5 additions & 5 deletions charts/appwrite/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,15 @@ annotations:
- name: builds
image: ghcr.io/open-runtimes/orchestrator/job-sidecar:5.1.0
- name: clickhouse
image: docker.io/clickhouse/clickhouse-server:26.8.36-alpine
image: docker.io/clickhouse/clickhouse-server:26.10.10-alpine
- name: console
image: docker.io/appwrite/new:1.2.181-self-hosted
- name: database
image: docker.io/appwrite/postgres:0.2.1
- name: database-exporter
image: quay.io/prometheuscommunity/postgres-exporter:v0.20.1
image: quay.io/prometheuscommunity/postgres-exporter:v0.21.1
- name: dind
image: docker.io/library/docker:29.9.3-dind
image: docker.io/library/docker:29.10.0-dind
- name: embedding
image: docker.io/appwrite/embedding:0.3.3
- name: executor
Expand All @@ -74,7 +74,7 @@ annotations:
- name: redis
image: docker.io/library/redis:7.4.12-alpine
- name: redis-exporter
image: docker.io/oliver006/redis_exporter:v1.96.0-alpine
image: docker.io/oliver006/redis_exporter:v1.97.0-alpine
- name: s3
image: docker.io/chrislusf/seaweedfs:4.52
image: docker.io/chrislusf/seaweedfs:4.54
artifacthub.io/displayName: Appwrite
10 changes: 5 additions & 5 deletions charts/appwrite/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ database:
# -- Image repository.
repository: prometheuscommunity/postgres-exporter
# -- Image tag.
tag: v0.20.1
tag: v0.21.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the postgres-exporter test expectation

This test only enables the exporter, so it renders the new default tag and compares it with v0.20.1; charts/appwrite/tests/extensions_test.yaml:136 will fail under the updated default. Please update the expected image along with this bump.

Prompt To Fix With AI
This is a comment left during a code review.
Path: charts/appwrite/values.yaml
Line: 376

Comment:
**Update the postgres-exporter test expectation**

This test only enables the exporter, so it renders the new default tag and compares it with `v0.20.1`; `charts/appwrite/tests/extensions_test.yaml:136` will fail under the updated default. Please update the expected image along with this bump.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

# -- Image digest.
digest: ""
# -- Image pull policy.
Expand Down Expand Up @@ -537,7 +537,7 @@ redis:
# -- Image repository.
repository: oliver006/redis_exporter
# -- Image tag.
tag: v1.96.0-alpine
tag: v1.97.0-alpine

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regenerate the chart README for the new image tag

charts/appwrite/README.md still lists redis.builtin.metrics.image.tag as v1.96.0-alpine. make check-generated runs make generate and will fail until the checked-in README reflects v1.97.0-alpine.

Prompt To Fix With AI
This is a comment left during a code review.
Path: charts/appwrite/values.yaml
Line: 540

Comment:
**Regenerate the chart README for the new image tag**

`charts/appwrite/README.md` still lists `redis.builtin.metrics.image.tag` as `v1.96.0-alpine`. `make check-generated` runs `make generate` and will fail until the checked-in README reflects `v1.97.0-alpine`.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Record the chart image updates in the changelog

This changes default deployed image versions, but CHANGELOG.md has no Unreleased entry. The chart-change check requires one unless the PR is labeled skip-changelog; please record the image updates.

Prompt To Fix With AI
This is a comment left during a code review.
Path: charts/appwrite/values.yaml
Line: 540

Comment:
**Record the chart image updates in the changelog**

This changes default deployed image versions, but `CHANGELOG.md` has no Unreleased entry. The chart-change check requires one unless the PR is labeled `skip-changelog`; please record the image updates.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

# -- Image digest.
digest: ""
# -- Image pull policy.
Expand Down Expand Up @@ -578,7 +578,7 @@ clickhouse:
# -- Image repository.
repository: clickhouse/clickhouse-server
# -- Image tag.
tag: 26.8.36-alpine
tag: 26.10.10-alpine
# -- Image digest.
digest: ""
# -- Image pull policy.
Expand Down Expand Up @@ -706,7 +706,7 @@ storage:
# -- Image repository.
repository: chrislusf/seaweedfs
# -- Image tag.
tag: "4.52"
tag: "4.54"
# -- Image digest.
digest: ""
# -- Image pull policy.
Expand Down Expand Up @@ -868,7 +868,7 @@ compute:
# -- Image repository of the Docker daemon, also used to start the executor.
repository: library/docker
# -- Image tag.
tag: 29.9.3-dind
tag: 29.10.0-dind

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the Docker-in-Docker test expectation

The executor test uses the default image and still expects 29.9.3-dind at charts/appwrite/tests/executor_test.yaml:183, so the unit-test suite fails with this new default. Please update that assertion alongside the image bump.

Prompt To Fix With AI
This is a comment left during a code review.
Path: charts/appwrite/values.yaml
Line: 871

Comment:
**Update the Docker-in-Docker test expectation**

The executor test uses the default image and still expects `29.9.3-dind` at `charts/appwrite/tests/executor_test.yaml:183`, so the unit-test suite fails with this new default. Please update that assertion alongside the image bump.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

# -- Image digest.
digest: ""
# -- Image pull policy.
Expand Down
Loading