Repository navigation
fix: apply locale formatting when precision is set - #376
Merged
Merged
Conversation
Merged
9 of 15 tasks
7 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the
precisionoption is set, the value is a string fromtoPrecision(), andtoLocaleString()on a string is a no-op — so the locale's decimal separator was ignored.filesize(1234, { locale: "sv", precision: 2 })returned1.2 kBinstead of1,2 kB.The fix coerces the string back to a number before locale formatting (only for non-zero values, so zero precision like
0.00is retained), letting the locale formatter apply its decimal separator.Type of Change
Related Issues
fixes #373
Testing
npm testpasses (272 tests, 100% coverage).npm run buildsucceeds. Added a regression test coveringsv,de-DE,en-US, precision 3, and negative values.Checklist
npm testpassesnpm run buildsucceedsScreenshots (if applicable)
N/A