Repository navigation
test(feature-flags): add e2e tests against AppConfig and the Agent extension - #5964
Merged
Merged
Conversation
…tension Deploy real AppConfig profiles and the AppConfig Agent Lambda extension to exercise appConfigStore, appConfigAgentStore, and appConfigVariantStore, including missing-flag fallbacks, variant selection by context, evaluateMany, and getEnabledFeatures. Add an under-privileged function without appconfig:GetLatestConfiguration: the SDK store must throw on access denial, while the Agent paths record the raw outcome so the observed shapes can be reported on the RFC. Also exercise Feature Flags from the Lambda layer e2e function. Fixes #5909
@aws-cdk/toolkit-lib calls propertiesHiddenByChangeSet from @aws-cdk/cloudformation-diff whenever a change set reaches CREATE_COMPLETE, but the lockfile still resolved cloudformation-diff to 2.187.0, which predates that export (added in 2.187.6). toolkit-lib declares the dependency as ^2, so dependabot's toolkit-lib bumps never moved it. Every e2e stack deployment failed with "propertiesHiddenByChangeSet is not a function", including the shared LMI capacity providers. Resolve cloudformation-diff to 2.187.7.
….com/aws-powertools/powertools-lambda-typescript into test/feature-flags-e2e-appconfig
dreamorosi
had a problem deploying
to
e2e-tests
November 13, 2026 11:37 — with
GitHub Actions
Failure
dreamorosi
had a problem deploying
to
e2e-tests
November 13, 2026 11:37 — with
GitHub Actions
Failure
dreamorosi
had a problem deploying
to
e2e-tests
November 13, 2026 11:37 — with
GitHub Actions
Failure
dreamorosi
had a problem deploying
to
e2e-tests
November 13, 2026 11:37 — with
GitHub Actions
Failure
dreamorosi
had a problem deploying
to
e2e-tests
November 13, 2026 11:37 — with
GitHub Actions
Failure
dreamorosi
had a problem deploying
to
e2e-tests
November 13, 2026 11:37 — with
GitHub Actions
Failure
dreamorosi
had a problem deploying
to
e2e-tests
November 13, 2026 11:39 — with
GitHub Actions
Failure
dreamorosi
had a problem deploying
to
e2e-tests
November 13, 2026 11:39 — with
GitHub Actions
Failure
AppConfig omits attribute values from a disabled variant, so the default variant resolves with no attributes. Also serialize the Agent /ping response in the annotation, which otherwise showed only its first line.
The first e2e run showed both Agent-backed stores throwing AppConfigAgentError with status 403 on access denial, consistently across runtimes and architectures. Assert that instead of accepting a fallback, so an extension change that hides the denial fails CI.
svozza
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end tests for Feature Flags that deploy real AppConfig profiles and the AppConfig Agent Lambda extension. They cover all three AppConfig stores and record how access denial looks through each retrieval path, which the RFC lists as unverified.
Changes
packages/feature-flags/tests/e2e/appConfigStores.test.ts: one function with the Agent layer attached, a freeform Flag Document profile, and a feature-flag profile with a basic flag and a multi-variant flag with a context ruleappConfigStoreandappConfigAgentStoreevaluation and missing-flag fallback; forappConfigVariantStore, assert two contexts selecting different variants, missing-flag fallback,evaluateMany, andgetEnabledFeatures/pingas a test annotationaccessDenied.test.ts: a function withappconfig:StartConfigurationSessionbut noappconfig:GetLatestConfiguration. The SDK store must throwGetParameterErrorcaused byAccessDeniedException, and the Agent and Variant stores must throwAppConfigAgentErrorwith status 403. Raw error shapes are recorded as annotationstests/helpers/resources.tswith the AppConfig test resources and the extension layer ARN map (version2.0.18836, same as the Parameters Agent e2e)@aws-cdk/cloudformation-diffin the lockfile from 2.187.0 to 2.187.7:@aws-cdk/toolkit-libcallspropertiesHiddenByChangeSet, which 2.187.0 does not export, so every e2e deployment failedtest:e2escripts so the package joins the e2e workflow matrix for both architecturesruleEngineStoreevaluation and anappConfigStorebuilt from the/appconfigsub-pathThe minimum extension version fix for the docs is in #5962. The RFC write-up of the IAM observations will follow once this suite has run in CI.
Issue number: closes #5909
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.