Skip to content

test(otel): cover replay and chained execution - #796

Open
zhongkechen wants to merge 3 commits into
fix/python-testing-replay-state-20261021from
test/python-otel-conformance-20261021
Open

zhongkechen wants to merge 3 commits into
fix/python-testing-replay-state-20261021from
test/python-otel-conformance-20261021

Conversation

@zhongkechen

@zhongkechen zhongkechen commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Add OpenTelemetry conformance coverage for replay, callback delivery, and chained child suspension through the public SDK APIs.

Coverage

  • Case 11: the caller replays its saved child result after a callback barrier, matching shared PR fix(sdk): fix timestamp format for checkpoint #131.

  • Case 21: completed steps reuse saved results during replay.

  • Cases 22–23: user-function and callback code retain the expected tracing context.

  • Case 24: invocation retry status is represented correctly.

  • Case 25: caught callback failures without error details retain the expected result, status and replay behavior.

  • Case 26: an externally completed callback reaches the exporter before the observed step runs. Its raw terminal export count remains one across both later replay barriers and final completion. Parent/trace identity and span timestamps are checked separately.

  • Case 27: a chained child suspends for a one-second durable wait, resumes, and returns the original payload; both tracing views check child continuation telemetry.

The change includes handlers, SAM/Makefile mappings, local integration tests, documentation and immutable workflow/catalog pins. Handlers use the Core 3 / OTel 2 factory API.

Stack

main → #758 → #795 → #796

#758 provides the Core/OTel runtime fixes. #795 aligns the local testing service's replay visibility and update acknowledgment with the service. This PR adds the conformance coverage that depends on those layers.

Validation

All 95 local OTel conformance handler checks and six workflow checks pass. Package lint and formatting pass. The new case uses the real registered child handler and verifies two caller and child invocations, stable wait identity, the saved payload, and view-specific continuation links. The workflow and manual dispatch use the shared 27-case catalog. Cloud conformance runs separately in CI.

Shared conformance #131, including the strengthened chained-invoke parent/ancestry qualification, remains a merge prerequisite. Local results do not replace that qualification.

Case 27 companions: JS #1068 and Java #824.

@github-actions

This comment has been minimized.

@zhongkechen zhongkechen mentioned this pull request Oct 21, 2026
7 of 11 tasks
@zhongkechen
zhongkechen added this pull request to stack #800 October 21, 2026 19:32
@zhongkechen
zhongkechen removed this pull request from stack #800 October 22, 2026 17:25
@zhongkechen
zhongkechen added this pull request to stack #809 October 22, 2026 17:25
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 22, 2026 17:28 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 22, 2026 21:03 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 22, 2026 23:26 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen force-pushed the test/python-otel-conformance-20261021 branch from 812e8bb to 14e6d62 Compare October 23, 2026 00:04
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 23, 2026 00:05 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen force-pushed the test/python-otel-conformance-20261021 branch from 14e6d62 to e4364ab Compare October 23, 2026 22:40
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 23, 2026 22:41 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@zhongkechen zhongkechen changed the title test(otel): cover replay and callback delivery test(otel): cover replay and chained execution Oct 23, 2026
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 23, 2026 23:02 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen force-pushed the test/python-otel-conformance-20261021 branch from 5403f3d to 9fe50ca Compare October 24, 2026 00:18
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime October 24, 2026 00:18 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen force-pushed the test/python-otel-conformance-20261021 branch from 9fe50ca to a8e8642 Compare October 24, 2026 01:35
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 24, 2026 01:36 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen force-pushed the test/python-otel-conformance-20261021 branch from a8e8642 to dfe7cf9 Compare October 24, 2026 02:38
@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 24, 2026 02:39 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. The prior export-order issue is resolved. Review was read-only; tests and cloud conformance runs were not executed.

Reviewed commit dfe7cf9e94bc24aae2dccaa3cbbf6dd04f764333. Workflow run

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — dfe7cf9e Deployed Oct 24, 2026 by zhongkechen via ai-pr-review / Codex review / Generate Codex review #2296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant