[srivilliamsai]

Issue #, if available

Fixes #860

Description of changes

Record callback terminal completions in updated_operation_ids when completing via complete_callback_success, complete_callback_failure, or complete_callback_timeout.

Design

See Rules for every change.

• Design note (rule 3): Not needed (internal testing package fix, no public API changes).
• Simpler options considered (rule 2): Reused the existing _record_updated_operation method rather than introducing custom tracking logic.
• Root cause (rule 5): complete_callback_success, complete_callback_failure, and complete_callback_timeout updated the operation sequence and status but did not invoke _record_updated_operation().
• Net change in source lines and in public API members: +3 lines in execution.py, 0 public API changes.

Assumptions

• Service parity: Callback completions delivered across an invocation boundary are presented in UpdatedOperationIds on the next execution input.

Decisions not covered by the issue or the design note

• None.

Checklist

• Every new branch has a test that fails without it (rule 4)
• For a bug fix: the first commit adds a test that fails on the current code (rule 5)
• Every edited test expectation is listed in the description, with the reason (rule 5)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[yaythomas]

Thank you very much, @srivilliamsai, and welcome to DEX!

#898: derive updated operation IDs merged today and fixed #860: Record callback terminal completions as updated operations a different way. The local runner now derives UpdatedOperationIds from the sequence numbers it records each time an operation changes, so a callback completion is listed without a separate call. That change also removed _record_updated_operation, so on main the three calls added here would raise AttributeError on every callback completion.

So I'm closing this one as superseded. Thanks again for picking up the issue!

[srivilliamsai]

Thanks for the warm welcome, @yaythomas! Makes total sense regarding #898. Glad to see #860 resolved—I'll look for the next open issue to contribute to! 🙌