Repository navigation
feat: install hyperpod-kubernetes-resource-monitor by default - #481
Merged
Merged
Conversation
Turn the hyperpod-kubernetes-resource-monitor subchart on by default, like health-monitoring-agent. Set hyperpod-kubernetes-resource-monitor.enabled=false to skip it. The SageMaker console already sends the value explicitly, so console installs are unchanged.
emeraldbay
requested a deployment
to
manual-approval
November 16, 2026 22:32 — with
GitHub Actions
Waiting
jam-jee
approved these changes
Nov 16, 2026
Collaborator
|
LGTM |
papriwal
approved these changes
Nov 16, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Turns the
hyperpod-kubernetes-resource-monitorsubchart on by default.HyperPodHelmChart/values.yaml:hyperpod-kubernetes-resource-monitor.enabledfalse->true. The comment now says how to skip it and thatregionshould be set.readme.md: "Enable by default" for the resource monitor is nowYes.Before/After UX
Before:
helm installof the HyperPod chart without extra values does not install the agent.After: the agent is installed. To skip it:
--set hyperpod-kubernetes-resource-monitor.enabled=false. Pass--set hyperpod-kubernetes-resource-monitor.region=<region>(as forhealth-monitoring-agent.region); on a cluster with no nodes yet the region cannot be read from a node label and the image comes from us-east-1.How was this change tested?
helm lint HyperPodHelmChart, default and withenabled=false: 0 failed.helm templatedefault: 9 agent objects, image767398015722.dkr.ecr.us-east-1.amazonaws.com/hyperpod-cluster-monitoring-agent:1.0.508.0_1.0.327.0; with
region=us-west-2:905418368575.dkr.ecr.us-west-2.amazonaws.com/....helm templatewithenabled=false: identical to the currentmaindefault (no agent objects).Are unit tests added?
No. Helm chart values only.
Are integration tests added?
No
Reviewer Guidelines
One of the following must be true: