Skip to content

feat: install hyperpod-kubernetes-resource-monitor by default - #481

Merged
papriwal merged 1 commit into
aws:mainfrom
emeraldbay:hkrma-enable-by-default
Nov 16, 2026
Merged

papriwal merged 1 commit into
aws:mainfrom
emeraldbay:hkrma-enable-by-default

Conversation

@emeraldbay

Copy link
Copy Markdown
Collaborator

What's changing and why?

Turns the hyperpod-kubernetes-resource-monitor subchart on by default.

  • HyperPodHelmChart/values.yaml: hyperpod-kubernetes-resource-monitor.enabled false -> true. The comment now says how to skip it and that region should be set.
  • readme.md: "Enable by default" for the resource monitor is now Yes.

Before/After UX

Before: helm install of the HyperPod chart without extra values does not install the agent.

After: the agent is installed. To skip it: --set hyperpod-kubernetes-resource-monitor.enabled=false. Pass --set hyperpod-kubernetes-resource-monitor.region=<region> (as for health-monitoring-agent.region); on a cluster with no nodes yet the region cannot be read from a node label and the image comes from us-east-1.

How was this change tested?

  • helm lint HyperPodHelmChart, default and with enabled=false: 0 failed.
  • helm template default: 9 agent objects, image 767398015722.dkr.ecr.us-east-1.amazonaws.com/hyperpod-cluster-monitoring-agent:1.0.508.0_1.0.327.0; wi
    th region=us-west-2: 905418368575.dkr.ecr.us-west-2.amazonaws.com/....
  • helm template with enabled=false: identical to the current main default (no agent objects).
  • The subchart itself (unchanged here) was installed from Hkrma nccl ras settings #480's head on HyperPod EKS clusters in us-west-2 and us-east-1 (2 x p5) and passed the chaos test suite.

Are unit tests added?

No. Helm chart values only.

Are integration tests added?

No

Reviewer Guidelines

‼️ Merge Requirements: PRs with failing integration tests cannot be merged without justification.

One of the following must be true:

  • All automated PR checks pass
  • Failed tests include local run results/screenshots proving they work
  • Changes are documentation-only

Turn the hyperpod-kubernetes-resource-monitor subchart on by default, like
health-monitoring-agent. Set hyperpod-kubernetes-resource-monitor.enabled=false
to skip it. The SageMaker console already sends the value explicitly, so
console installs are unchanged.
@emeraldbay
emeraldbay requested a review from a team as a code owner November 16, 2026 22:31
@huaziyao

Copy link
Copy Markdown
Collaborator

LGTM

@papriwal
papriwal merged commit 1183324 into aws:main Nov 16, 2026
1 of 2 checks passed

This branch is waiting to be deployed

1 waiting deployment
manual-approval — afd56d59 Waiting Nov 16, 2026 by emeraldbay via wait-for-approval #847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants