Skip to content

feat: add hyperpod-resource-ownership subchart, disabled by default - #483

Closed
meghanajs99 wants to merge 1 commit into
aws:mainfrom
meghanajs99:release-resource-ownership
Closed

meghanajs99 wants to merge 1 commit into
aws:mainfrom
meghanajs99:release-resource-ownership

Conversation

@meghanajs99

Copy link
Copy Markdown
Contributor

What's changing and why?

Adds HyperPod resource ownership to the HyperPod Helm chart as the hyperpod-resource-ownership subchart. It records who created each RayJob, HyperPodPyTorchJob, InferenceEndpointConfig and JumpStartModel, and lets only the creator, the operators and cluster admins update or delete the ones marked OwnerOnly.

The subchart is disabled by default (hyperpod-resource-ownership.enabled: false). Existing installs and upgrades are unchanged unless it is turned on.

Changes:

  • HyperPodHelmChart/Chart.yaml: new dependency hyperpod-resource-ownership (file://), with condition: hyperpod-resource-ownership.enabled.
  • HyperPodHelmChart/values.yaml: hyperpod-resource-ownership block, enabled: false.
  • charts/hyperpod-resource-ownership/: the mutating webhook that records the creator, ValidatingAdmissionPolicies that enforce OwnerOnly (including status and scale writes), the webhook Deployment, Service, PodDisruptionBudget and ServiceAccount, and cert-manager Issuer and Certificate for its TLS.
  • The webhook image comes from the regional HyperPod ECR repository for the 14 supported Regions (region, then global.region), by tag (default 1.0.20.0_1.0.3.0) or by image.digest. image.override sets the full URI.
  • helm_chart/readme.md: new row in the components table.

Before/After UX

Before:
The HyperPod Helm chart has no resource ownership.

After:
Default install: no change; the subchart renders no objects.

Opt in (requires cert-manager and Kubernetes 1.30+):

helm install dependencies HyperPodHelmChart --namespace kube-system \
  --set cert-manager.enabled=true \
  --set hyperpod-resource-ownership.enabled=true \
  --set global.region=<region>

How was this change tested?

  • helm dependency update + helm lint HyperPodHelmChart: 0 failed, with the subchart off and on.
  • helm template (default): 0 objects from the subchart.
  • helm template --set hyperpod-resource-ownership.enabled=true --set global.region=<region>: renders the webhook, policies and certificates; the image is the right regional account and tag in each of the 14 Regions, and image.digest renders repository@sha256:….
  • The image hyperpod-resource-ownership-webhook:1.0.20.0_1.0.3.0 exists in all 14 regional ECR repositories (one digest).
  • The subchart is the same as the one in the staging repository, which was installed on live HyperPod EKS clusters and covered by the resource ownership integration tests and canaries.

Are unit tests added?

No; this adds a Helm subchart. The webhook and policies are tested in their own packages.

Are integration tests added?

No in this repository; the resource ownership integration tests run against live clusters in its pipeline.

Records who created each RayJob, HyperPodPyTorchJob, InferenceEndpointConfig and
JumpStartModel, and lets only the creator, the operators and cluster admins update or
delete the ones marked OwnerOnly. The webhook image is resolved per region from the
HyperPod ECR accounts, by tag (default 1.0.20.0_1.0.3.0) or by digest.
@meghanajs99
meghanajs99 requested a review from a team as a code owner November 21, 2026 20:29
@meghanajs99

Copy link
Copy Markdown
Contributor Author

Closing in favor of a single sync PR that merges the staging repository's master into main, once the staging PRs for these charts have merged.

@meghanajs99
meghanajs99 deleted the release-resource-ownership branch November 21, 2026 20:32

This branch is waiting to be deployed

1 waiting deployment
manual-approval — c6b3feea Waiting Nov 21, 2026 by meghanajs99 via wait-for-approval #851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant