Repository navigation
feat: add hyperpod-compute-configuration subchart, disabled by default - #484
Closed
meghanajs99 wants to merge 1 commit into
Closed
meghanajs99 wants to merge 1 commit into
meghanajs99 wants to merge 1 commit into
Conversation
Installs the ComputeConfiguration CRD and its admission webhook: an admin defines named compute shapes in a namespace, and a RayJob, HyperPodPyTorchJob or InferenceEndpointConfig that references one gets its compute filled in and checked. The webhook image is resolved per region from the HyperPod ECR accounts, by tag (default 1.0.24.0_1.0.5.0) or by digest; an override must be pinned by digest.
meghanajs99
requested a deployment
to
manual-approval
November 21, 2026 20:30 — with
GitHub Actions
Waiting
Contributor
Author
|
Closing in favor of a single sync PR that merges the staging repository's master into main, once the staging PRs for these charts have merged. |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Adds HyperPod compute configurations to the HyperPod Helm chart as the
hyperpod-compute-configurationsubchart. It installs theComputeConfigurationCRD and its admission webhook: an admin defines named compute shapes in a namespace, and a RayJob, HyperPodPyTorchJob or InferenceEndpointConfig that references one (labelcompute.configuration.sagemaker.amazonaws.com/name) gets its compute filled in and checked. Namespaces labeledcompute.configuration.sagemaker.amazonaws.com/enforcement=enabledrequire every workload to use one.The subchart is disabled by default (
hyperpod-compute-configuration.enabled: false). Existing installs and upgrades are unchanged unless it is turned on.Changes:
HyperPodHelmChart/Chart.yaml: new dependencyhyperpod-compute-configuration(file://), withcondition: hyperpod-compute-configuration.enabled.HyperPodHelmChart/values.yaml:hyperpod-compute-configurationblock,enabled: false.charts/hyperpod-compute-configuration/: theComputeConfigurationCRD, admin/editor/viewer ClusterRoles, the mutating and validating webhooks, ValidatingAdmissionPolicies (workloads,unsupported-kinds) that work even when the webhook is down, the webhook Deployment, Service, PodDisruptionBudget, ServiceAccount and RBAC, and cert-manager Issuer and Certificate for its TLS.region, thenglobal.region), by tag (default1.0.24.0_1.0.5.0) or bywebhook.image.digest.webhook.image.overridesets the full URI and must be pinned by digest; the render fails otherwise.webhook.enable: falseinstalls only the CRD.helm_chart/readme.md: new row in the components table.Before/After UX
Before:
The HyperPod Helm chart has no compute configurations.
After:
Default install: no change; the subchart renders no objects.
Opt in (requires cert-manager and Kubernetes 1.30+):
How was this change tested?
helm dependency update+helm lint HyperPodHelmChart: 0 failed, with the subchart off and on.helm template(default): 0 objects from the subchart.helm template --set hyperpod-compute-configuration.enabled=true --set global.region=<region>: renders the CRD, webhooks, policies and certificates; the image is the right regional account and tag in each of the 14 Regions,webhook.image.digestrendersrepository@sha256:…, and an override pinned by tag fails the render.Are unit tests added?
No; this adds a Helm subchart. The webhook and policies are tested in their own packages.
Are integration tests added?
No in this repository; the compute configuration integration tests run against live clusters in its pipeline.