Skip to content

feat: add hyperpod-compute-configuration subchart, disabled by default - #484

Closed
meghanajs99 wants to merge 1 commit into
aws:mainfrom
meghanajs99:release-compute-configuration
Closed

meghanajs99 wants to merge 1 commit into
aws:mainfrom
meghanajs99:release-compute-configuration

Conversation

@meghanajs99

Copy link
Copy Markdown
Contributor

What's changing and why?

Adds HyperPod compute configurations to the HyperPod Helm chart as the hyperpod-compute-configuration subchart. It installs the ComputeConfiguration CRD and its admission webhook: an admin defines named compute shapes in a namespace, and a RayJob, HyperPodPyTorchJob or InferenceEndpointConfig that references one (label compute.configuration.sagemaker.amazonaws.com/name) gets its compute filled in and checked. Namespaces labeled compute.configuration.sagemaker.amazonaws.com/enforcement=enabled require every workload to use one.

The subchart is disabled by default (hyperpod-compute-configuration.enabled: false). Existing installs and upgrades are unchanged unless it is turned on.

Changes:

  • HyperPodHelmChart/Chart.yaml: new dependency hyperpod-compute-configuration (file://), with condition: hyperpod-compute-configuration.enabled.
  • HyperPodHelmChart/values.yaml: hyperpod-compute-configuration block, enabled: false.
  • charts/hyperpod-compute-configuration/: the ComputeConfiguration CRD, admin/editor/viewer ClusterRoles, the mutating and validating webhooks, ValidatingAdmissionPolicies (workloads, unsupported-kinds) that work even when the webhook is down, the webhook Deployment, Service, PodDisruptionBudget, ServiceAccount and RBAC, and cert-manager Issuer and Certificate for its TLS.
  • The webhook image comes from the regional HyperPod ECR repository for the 14 supported Regions (region, then global.region), by tag (default 1.0.24.0_1.0.5.0) or by webhook.image.digest. webhook.image.override sets the full URI and must be pinned by digest; the render fails otherwise.
  • webhook.enable: false installs only the CRD.
  • helm_chart/readme.md: new row in the components table.

Before/After UX

Before:
The HyperPod Helm chart has no compute configurations.

After:
Default install: no change; the subchart renders no objects.

Opt in (requires cert-manager and Kubernetes 1.30+):

helm install dependencies HyperPodHelmChart --namespace kube-system \
  --set cert-manager.enabled=true \
  --set hyperpod-compute-configuration.enabled=true \
  --set global.region=<region>

How was this change tested?

  • helm dependency update + helm lint HyperPodHelmChart: 0 failed, with the subchart off and on.
  • helm template (default): 0 objects from the subchart.
  • helm template --set hyperpod-compute-configuration.enabled=true --set global.region=<region>: renders the CRD, webhooks, policies and certificates; the image is the right regional account and tag in each of the 14 Regions, webhook.image.digest renders repository@sha256:…, and an override pinned by tag fails the render.
  • The subchart is the same as the one in the staging repository, which was installed on live HyperPod EKS clusters and covered by the compute configuration integration tests and canaries.

Are unit tests added?

No; this adds a Helm subchart. The webhook and policies are tested in their own packages.

Are integration tests added?

No in this repository; the compute configuration integration tests run against live clusters in its pipeline.

Installs the ComputeConfiguration CRD and its admission webhook: an admin defines named
compute shapes in a namespace, and a RayJob, HyperPodPyTorchJob or InferenceEndpointConfig
that references one gets its compute filled in and checked. The webhook image is resolved
per region from the HyperPod ECR accounts, by tag (default 1.0.24.0_1.0.5.0) or by digest;
an override must be pinned by digest.
@meghanajs99

Copy link
Copy Markdown
Contributor Author

Closing in favor of a single sync PR that merges the staging repository's master into main, once the staging PRs for these charts have merged.

@meghanajs99
meghanajs99 deleted the release-compute-configuration branch November 21, 2026 20:32

This branch is waiting to be deployed

1 waiting deployment
manual-approval — 858ee5a9 Waiting Nov 21, 2026 by meghanajs99 via wait-for-approval #852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant