Repository navigation
feat: add hyperpod-resource-ownership and hyperpod-compute-configuration subcharts, disabled by default - #485
Merged
Merged
Conversation
papriwal
approved these changes
Nov 22, 2026
…ion subcharts, disabled by default hyperpod-resource-ownership records who created each RayJob, HyperPodPyTorchJob, InferenceEndpointConfig and JumpStartModel (the created-by annotation) and lets only the creator, the operators and cluster admins update or delete the ones marked OwnerOnly, including through their status and scale subresources. The owner can change ownership-type; created-by is immutable. hyperpod-compute-configuration installs the ComputeConfiguration CRD and its admission webhook. An admin defines named compute shapes in a namespace; a RayJob, HyperPodPyTorchJob or InferenceEndpointConfig that references one by label gets its compute filled in and checked, and namespaces labelled compute.configuration.sagemaker.amazonaws.com/enforcement=enabled require every such workload to use one. Both webhook images come from the regional HyperPod ECR repository for the 14 supported Regions, by tag or by digest; an image override must be pinned by digest. Both require cert-manager and Kubernetes 1.30+.
meghanajs99
force-pushed
the
release-ro-cc
branch
from
November 22, 2026 01:52
a09d0e8 to
7a0b3ba
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Adds two HyperPod components to the HyperPod Helm chart as subcharts, both disabled by default:
hyperpod-resource-ownership: records who created each RayJob, HyperPodPyTorchJob, InferenceEndpointConfig and JumpStartModel, and lets only the creator, the operators and cluster admins update or delete the ones markedOwnerOnly. A mutating webhook records the creator; ValidatingAdmissionPolicies enforceOwnerOnly, including status and scale writes.hyperpod-compute-configuration: theComputeConfigurationCRD and its admission webhook. An admin defines named compute shapes in a namespace; a RayJob, HyperPodPyTorchJob or InferenceEndpointConfig that references one (labelcompute.configuration.sagemaker.amazonaws.com/name) gets its compute filled in and checked. Namespaces labelledcompute.configuration.sagemaker.amazonaws.com/enforcement=enabledrequire every such workload to use one.Both webhook images come from the regional HyperPod ECR repository for the 14 supported Regions (
region, thenglobal.region), by tag (defaults: resource ownership1.0.20.0_1.0.3.0, compute configuration1.0.26.0_1.0.5.0) or by digest. Both need cert-manager and Kubernetes 1.30+.Changes:
charts/hyperpod-resource-ownership/andcharts/hyperpod-compute-configuration/: the subcharts.HyperPodHelmChart/Chart.yaml: twofile://dependencies withcondition: <name>.enabled.HyperPodHelmChart/values.yaml:enabled: falseblocks for both.helm_chart/readme.md: two rows in the components table.main'shyperpod-kubernetes-resource-monitorentries in the parentChart.yaml,values.yamlandreadme.mdare unchanged; the new entries follow them. Nothing else inmainchanges (0 deleted lines).Before/After UX
Before: the HyperPod Helm chart has neither component.
After: default install: no change; neither subchart renders any objects. Opt in:
How was this change tested?
helm dependency update+helm lint HyperPodHelmChart: 0 failed, with both subcharts off and on.helm template(default): no objects from either subchart;hyperpod-kubernetes-resource-monitorstill on by default;hyperpod-inference-operatorstill 2.8.3.helm templatewith both enabled renders each Region's account and the default tags; both images exist in all 14 Regions' ECR repositories (compute configuration1.0.26.0_1.0.5.0:sha256:1f4b89be…57d4; resource ownership1.0.20.0_1.0.3.0:sha256:2adcad86…f57a).Are unit tests added?
No; this adds Helm subcharts. The webhooks and policies are tested in their own packages.
Are integration tests added?
Not in this repository; each component's integration tests run against live clusters in its pipeline.